Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update community-plugin-marketplace.md #929

Merged
merged 8 commits into from
Sep 15, 2021
Merged

Update community-plugin-marketplace.md #929

merged 8 commits into from
Sep 15, 2021

Conversation

justinegeffen
Copy link
Contributor

Replaced content with content from #747.

Content changes are from a while back but were not merged. They include more details around the type of documentation required, as well as an update on the language/terminology. Linked to mattermost/mattermost-marketplace#210 but not dependent on it.

@justinegeffen
Update community-plugin-marketplace.md
d33b9c8 
Replaced content with content from #747.
@justinegeffen justinegeffen added the 1: Dev Review Requires review by a core commiter label Sep 2, 2021
@github-actions
Copy link

github-actions bot commented Sep 2, 2021

Newest code from justinegeffen has been published to preview environment for Git SHA d33b9c8

hanzei
hanzei requested changes Sep 3, 2021
View reviewed changes
Copy link
Contributor

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Justine!

site/content/integrate/plugins/community-plugin-marketplace.md Outdated Show resolved Hide resolved
site/content/integrate/plugins/community-plugin-marketplace.md Outdated Show resolved Hide resolved
site/content/integrate/plugins/community-plugin-marketplace.md Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Sep 6, 2021

Newest code from justinegeffen has been published to preview environment for Git SHA c4983d1

justinegeffen
justinegeffen commented Sep 6, 2021
View reviewed changes
site/content/integrate/plugins/community-plugin-marketplace.md Outdated

### Technical Requirements (Checked by developers of the Toolkit or the Integrations team)
**Technical requirements (checked by developers of the Toolkit team or the Integrations team)**
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**Technical requirements (checked by developers of the Toolkit team or the Integrations team)**
**Technical requirements (checked by developers of the Interstellar team)**

@github-actions
Copy link

github-actions bot commented Sep 6, 2021

Newest code from justinegeffen has been published to preview environment for Git SHA 8ce7b43

@github-actions
Copy link

github-actions bot commented Sep 6, 2021

Newest code from justinegeffen has been published to preview environment for Git SHA 18587bf

hanzei
hanzei approved these changes Sep 6, 2021
View reviewed changes
Copy link
Contributor

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@github-actions
Copy link

github-actions bot commented Sep 6, 2021

Newest code from justinegeffen has been published to preview environment for Git SHA a3d66e3

@github-actions
Copy link

github-actions bot commented Sep 6, 2021

Newest code from justinegeffen has been published to preview environment for Git SHA c522f0c

@github-actions
Copy link

github-actions bot commented Sep 8, 2021

Newest code from justinegeffen has been published to preview environment for Git SHA 38850f3

BenLloydPearson
BenLloydPearson approved these changes Sep 14, 2021
View reviewed changes
Copy link
Contributor

@BenLloydPearson BenLloydPearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one comment, but this looks great otherwise.

site/content/integrate/plugins/community-plugin-marketplace.md Outdated

### Technical Requirements (Checked by developers of the Toolkit or the Integrations team)
**Technical requirements (checked by developers of the Interstellar team)**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will external developers know what "Interstellar team" refers to?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question! We can change this to "Checked by the relevant development team".

@justinegeffen justinegeffen added 4: Reviews Complete All reviewers have approved the pull request and removed 1: Dev Review Requires review by a core commiter labels Sep 15, 2021
@github-actions
Copy link

Newest code from justinegeffen has been published to preview environment for Git SHA 81bd27d

@justinegeffen justinegeffen merged commit 714f338 into master Sep 15, 2021
@justinegeffen justinegeffen deleted the justinegeffen-new-marketplace-content branch September 15, 2021 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenLloydPearson BenLloydPearson BenLloydPearson approved these changes

@hanzei hanzei hanzei approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@justinegeffen @BenLloydPearson @hanzei