deactivate TLSv1 by default

[cht47]

Hi,
today I've seen that TLS 1.0 and 1.1 is on by default under web/mattermost-ssl
ssl_protocols TLSv1 TLSv1.1 TLSv1.2;

I recommend to reject at least TLSv1. Would be nice if we could edit it in the docker-compose.yml.

[pichouk]

I'm okay to remove TLS1.0 since it seems that TLS1.1 is widely supported. If you have some others suggestions to improve TLS security on the web image I'll be happy to hear about them.

Would you like to submit a PR ? If yes, fell free to submit. Otherwise I can make the change.

[cht47]

Thanks, but you can make the change.

As I don't use the standard HTTPS port SSLLabs doesn't work for me to check for further vulnerabilities.

A recommendation (for a TLS1.2 config):
ssl_ciphers ECDHE-ECDSA-CHACHA20-POLY1305:ECDHE-ECDSA-AES128-GCM-SHA256:ECDHE-ECDSA-AES128-SHA;
There is a huge explanation why these and why this order. Mozilla gives some information about this too.
Mozilla
and here you have a generator:
https://mozilla.github.io/server-side-tls/ssl-config-generator/

Enabling HSTS would also be something to think about it. But that can be annoying with cert problems so I don't recommend it for this project.

Edit:
here are the settings my company uses for our cloud products. Our webservices get tested by external security experts, we got a very good rating last time so it should be save and still usable for "older" browsers (we also support tls1.1)
SSLCipherSuite EECDH+AESGCM:EDH+AESGCM:AES256+EECDH:ECDHE-RSA-AES128-SHA:DHE-RSA-AES128-GCM-SHA256:AES256+EDH:ECDHE-RSA-AES256-GCM-SHA384:ECDHE-RSA-AES128-GCM-SHA256:DHE-RSA-AES256-GCM-SHA384:ECDHE-RSA-AES256-SHA384:ECDHE-RSA-AES128-SHA256:ECDHE-RSA-AES256-SHA:DHE-RSA-AES256-SHA256:DHE-RSA-AES128-SHA256:DHE-RSA-AES256-SHA:DHE-RSA-AES128-SHA:AES256-GCM-SHA384:AES128-GCM-SHA256:AES256-SHA256:AES128-SHA256:AES256-SHA:AES128-SHA:HIGH:!aNULL:!eNULL:!EXPORT:!DES:!MD5:!PSK:!RC4:!DES:!3DES

[cht47]

a little update from my side. I will update my container to 5.0 soon and then test some "casual" security configurations without TLSv1 and then some stronger configurations. Then I test it some weeks (colleagues will be my Guinea pigs) and then you will hear from me again with a proper tested working config.

[minj]

security > interoperability

drop everything but v1.2, let the unfortunate souls misconfigure their servers on their own

[J0WI]

TLSv1.3 support has just been added to nginx on Alpine.

[pichouk]

We will probably deprecate the web image with #366