WIP Deprecate the web image and the default Docker Compose file

[pichouk]

Almost a year ago I started a discussion to, eventually, drop the support of the web image. Finally, I submit this change.

Also I suggest to remove the default docker-compose.yml file from the repository and propose an example (based on Traefik) instead, under the contrib folder.

---

The reason to drop support of the web image have been discussed on #245 but, to sum-up, it's because the image is just a simple Nginx server, with absolutely no value added. Instead, users should use their existing reverse-proxy.

The reason to remove the docker-compose.yml file is because it is not very useful. Actually, lots of people wants to add new, specific, features (eg. #203 #266 #285 #195) and we can't maintain a huge file that match everyone's needs. Furthermore, Docker Compose is only one way to deploy Docker containers, a lot of other different ways exists (Docker commands, Swarm, Kubernetes, etc.) and I think the main goal of this repository should be to maintain a Docker image for Mattermost.
In order to not leave users with nothing, I moved the docker-compose.yml (with some important updates) to the contrib/traefik folder, as an example.

I'll appreciate to have reviews and opinions about this (from Mattermost and community members) because this is a big change for this repository.

---

Checklist before merging this PR :

• Discuss about it, collect reviews/opinions and adjust (or abandon)
• Write and submit a PR to update the Mattermost documentation
• Prepare a "breaking change note" for users and communicate about it (with help of @jasonblais I guess ?)
• Wait for Mattermost 6.0, rebase and manage conflicts with PR replace port 8000 to the default one and add gossip and stream ports #326 (which is also a breaking change)
• Merge and tag new images (as usual)

[jasonblais]

@pichouk Thank you, this is a great approach for the PR. Agree with your checklist.

We're preparing a list of "v6.0 breaking changes" and have taken note of this. Will work with you on how to best communicate in a few weeks.

[jwilander]

Focusing this repository on the Docker image itself makes a lot of sense to me 👍

[kratan]

Ohh, i liked the current version of mattermost-docker with docker-compose. So I can have a All in One solution. Other projects like Nextcloud maintaining stacks there all is included. So ppl can relative easy setup a best practice solution.
If you drop the web image user have to care about an own solution, mostly ending in a not secure installation.

greets

[tbpoetke]

Ohh, i liked the current version of mattermost-docker with docker-compose. So I can have a All in One solution. Other projects like Nextcloud maintaining stacks there all is included. So ppl can relative easy setup a best practice solution.
If you drop the web image user have to care about an own solution, mostly ending in a not secure installation.

greets

Still working with an example file. I´m using my own compose file, my own reverse proxy and every pull overwrites my compose file. And people can still make their own stack and publish on Github, but here is the mattermost site, not NGINX or Mattermost+NGINX site, just my 2 cents...

[pichouk]

Other projects like Nextcloud maintaining stacks there all is included. So ppl can relative easy setup a best practice solution.

Actually we will do the same as the nextcloud/docker repository. They provide few examples as we do with the contrib folder.

If you drop the web image user have to care about an own solution, mostly ending in a not secure installation.

IMHO pulling a "ready-to-use" docker-compose.yml file is insecure. But reading some examples, understanding how it works and use the right tools matching your needs is way more secure.

[cpanato]

also we will use the port 8065 instead of 8000. this was already posted in the channel

[jasonblais]

Yeah, I've got a ticket to track it: https://mattermost.atlassian.net/browse/MM-13614

[mattermod]

This issue has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

/cc @jasonblais @hanzei

[hanzei]

@pichouk What is the status on this PR? Do this need design, work or review?

[pichouk]

Hi @hanzei
This PR is waiting for Mattermost 6.0 release. Also I need to write some documentation for mattermost/docs. So it's not really stale, just waiting for next major release.

[jasonblais]

I don't have permissions, but we can add a Lifecycle/frozen label to indicate the PR is frozen and re-activated closer to our 6.0 release

[pichouk]

Good idea ! Would you like to close the PR too ?

Also, I assume that we agree on this PR (first point on checklist) so I'll start writing some doc for Mattermost Docker documentation page.

[jasonblais]

I think we can keep the PR open for visibility.

Also, I assume that we agree on this PR (first point on checklist) so I'll start writing some doc for Mattermost Docker documentation page.

@jwilander confirming we've decided on this approach for Mattermost 6.0 onward?

[jwilander]

Yes, we're agreed that this is the right path forward.

[jasonblais]

Great! Then starting to write document updates is a good next step @pichouk

[pichouk]

I tried a first shot for the new documentation. I don't know if I should open a PR to get reviews or wait to be closer to the Mattermost 6.0 release ?

[westurner]

Questions these docs could help answer: Is it recommended to have a load balancer / reverse proxy normalizing and logging HTTP requests with just one instance of mattermost? What are the optimal / recommended buffer settings?

…

On Sunday, April 28, 2019, Kyâne Pichou ***@***.***> wrote: I tried a first shot <pichouk/docs@9659a03> for the new documentation. I don't know if I should open a PR to get reviews or wait to be closer to the Mattermost 6.0 release ? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#366 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAMNSZU37TV7QLEICE2JCLPSXV4LANCNFSM4GWKWQXA> .

[jasonblais]

I don't know if I should open a PR to get reviews or wait to be closer to the Mattermost 6.0 release ?

Opening a PR seems fine, the community can also more easily share feedback / suggestions on the documentation, such as those shared by @westurner above

[pichouk]

It seems I forgot to opened the Pull Request. I just did it : mattermost/docs#2709

[cpanato]

this repository is no longer maintained see: https://github.com/mattermost/mattermost-docker#readme

we made a new place for docker related https://github.com/mattermost/docker

closing this PR, thanks for your contribution