This repository has been archived by the owner on May 20, 2022. It is now read-only.
web entrypoint: forcefully link existing config #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How can I re-run the cla/mattermost check? Force push last commit with new timestamp? :) |
|
/check-cla |
cpanato
approved these changes
Mar 13, 2020
lvnilesh
added a commit
to beacloudgenius/mattermost-docker
that referenced
this pull request
Mar 27, 2020
* 'v5.21' of https://github.com/mattermost/mattermost-docker: bump mm prod app to 5.21.0 bump mm prod app to 5.20.2 web entrypoint: forcefully link existing config (mattermost#454)
nickygerritsen
added a commit
to Lets-Talk-NL/mattermost-docker
that referenced
this pull request
Jun 29, 2020
* upstream/master: (54 commits) bump to 5.24.2 bump MM to 5.24.1 bump MM to 5.24.0 Update Dockerfile (mattermost#476) Add ?src=docker-app query parameter to identify download source (mattermost#475) bump docker app to 5.23.0 Fix : certificate signed by unknown authority refs : mattermost/mattermost#13059 (mattermost#474) bump app dockerfile to 5.22.3 Fixing docker-compose build process (mattermost#471) bump mm to 5.22.1 Update Dockerfile (mattermost#467) docker-compose: fix DB Docker building error mattermost#463 related wal-e 1.0.0 and azure (mattermost#464) allow uncommenting for team edition (mattermost#433) Fix the linking of the nginx configuration file (mattermost#458) docker-compose: remove unused ENV variable (mattermost#456) bump mm prod app to 5.21.0 bump mm prod app to 5.20.2 web entrypoint: forcefully link existing config (mattermost#454) Remove deprecated nginx ssl directive (mattermost#451) (mattermost#452) bump mm prod app to 5.20.1 ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to enable SSL, I added the certificate as described here: https://github.com/mattermost/mattermost-docker#install-with-ssl-certificate
However, the web server was still listenting to port 80 instead of port 443 and it took me a moment to see why. The startup output of docker-compose contains this:
While the second line suggests, that the config mattermost-ssl is being used, the first line tells us, that the linking was not successful, because the symlink already exists from a previous execution. The existing link can be overwritten by adding
-f --forcetoln.Related: #366 (#366 would probably need to be updated with the same change)