Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add v2.1.5 of mattermost-plugin-github to the Marketplace #356

Merged
merged 4 commits into from
Apr 12, 2023
Merged

Add v2.1.5 of mattermost-plugin-github to the Marketplace #356

merged 4 commits into from
Apr 12, 2023

Conversation

mickmister
Copy link
Contributor

@mickmister mickmister added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Mar 31, 2023
@hanzei hanzei removed the 2: Dev Review Requires review by a core committer label Apr 4, 2023
DHaussermann
DHaussermann approved these changes Apr 11, 2023
View reviewed changes
Copy link

@DHaussermann DHaussermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and passed

  • Tested install path
  • Tested upgrade path
  • Marketplace link points to repo as expected
  • No changes to icon
  • Version correctly showing as 2.1.5

LGTM!

@DHaussermann DHaussermann added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Apr 11, 2023
@mickmister mickmister mentioned this pull request Apr 11, 2023
Merged
@mickmister mickmister merged commit f7a12ec into production Apr 12, 2023
@mickmister mickmister deleted the github-2.1.5 branch April 12, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m1lt0n m1lt0n m1lt0n approved these changes

@hanzei hanzei hanzei approved these changes

@DHaussermann DHaussermann DHaussermann approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mickmister @m1lt0n @hanzei @DHaussermann