Fix linting rule: Use underscore to convey unused variable #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanzei
approved these changes
Apr 11, 2023
trilopin
approved these changes
Apr 12, 2023
hanzei
added
the
4: Reviews Complete
lieut-data
added a commit
that referenced
this pull request
Dec 8, 2023
* Update add_plugin.md * Update add_plugin.md * Update add_plugin.md * [MM-39133] Update Marketplace labels for new SKUs (#224) * Update add_plugin.md * Update add_plugin.md * Update icon URL from mattermost.org to mattermost.com (#269) * change "Enterprise and Cloud" to "Professional/Enterprise" * gofmt * Change "license to run" to "subscription" Co-authored-by: Jason Blais <13119842+jasonblais@users.noreply.github.com> * Use mattermost-server/v6 (#283) * Correctly set ReturnAllVersions and PluginID for upstream requests (#268) * MM-49609 - Update mattermost-server version (#333) * update mattermost-server version * remove ioutil * remove deprecated linters, add revive * experimenting with go and node circleci upgrades * fix * fix * go 1.19, revive, fix new linter errors * fix golangci-lint-version to match dep orb * fix comment * use same golangci-lint as plugins * fix failing build? * testing... * remove unneeded gotest/tools * fix * MM-50203 - Update serverless (#338) * Allow adding plugins with an invalid manifest to the Marketplace (#340) * Downgrade node version to 12 (#343) * Always pull tags from master (#344) * use underscore to convey unused variable (#360) * Migrate to GHA: implement build jop * Fix GHA workflow * Fix workflow file * Fix workflow: ensure local master branch exists * Fix workflow file: only persist build artifacts * Debug workflow file * Fix node image permissions * Add conditions to workflow steps * Fix deploy job conditions * Optimize workflow conditionals * Remove double newline * Debug serverless command availability * Remove safety echo for actual deploys * Emulate master merge to trigger a staging env deploy * Debug ref name for push event * Fix deploy conditions * Debug deploy dir content * Use node 12 * Bump node and serverless versions * Restore corretct deploy condition * Add uncommitted changes check step * Fix typo * Check for master branch existence before creating it * Clean up command output * CLD-6708 Increase serverless verbosity, persist lambda artifact (#401) Increase serverless verbosity, persist lambda artifact * simplify setting BUILD_UPSTREAM_URL via CI env: directive --------- Co-authored-by: Justine Geffen <justinegeffen@users.noreply.github.com> Co-authored-by: Ben Schumacher <ben.schumacher@mattermost.com> Co-authored-by: Michael Kochell <mjkochell@gmail.com> Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com> Co-authored-by: Jason Blais <13119842+jasonblais@users.noreply.github.com> Co-authored-by: Christopher Poile <cpoile@gmail.com> Co-authored-by: Mario Vitale <mvitale1989@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The CI checks on #356 are currently failing due to a linting error regarding unused function parameter
r *http.Request. This PR fixes the issue by using underscores to convey that this is not used.Ticket Link