Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MM-39133] Update Marketplace labels for new SKUs #224

Merged
merged 2 commits into from
Oct 8, 2021
Merged

[MM-39133] Update Marketplace labels for new SKUs #224

merged 2 commits into from
Oct 8, 2021

Conversation

hanzei
Copy link
Collaborator

@hanzei hanzei commented Oct 6, 2021

Summary

Update Marketplace labels for new SKUs

Ticket Link

https://mattermost.atlassian.net/browse/MM-39133

@hanzei hanzei added 1: PM Review Requires review by a product manager 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Oct 6, 2021
aaronrothschild
aaronrothschild approved these changes Oct 6, 2021
View reviewed changes
Copy link
Contributor

@aaronrothschild aaronrothschild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aaronrothschild aaronrothschild removed the 1: PM Review Requires review by a product manager label Oct 6, 2021
@hanzei hanzei removed the 2: Dev Review Requires review by a core committer label Oct 6, 2021
@hanzei hanzei removed the request for review from mickmister October 6, 2021 16:44
@DHaussermann
Copy link

DHaussermann commented Oct 6, 2021 •
edited
Loading

@hanzei and @aaronrothschild this looks quite awkward when the label wraps.
image
Is there a simple way we could improve this?

  • Move labels to a new line?
  • Make this 4 separate labels?
  • Improve the look slightly by adding a few pixel of back color beyond the edges of the text?
  • Other thought?

@catalintomai
Copy link
Contributor

Maybe remove the "AND" ?

@aaronrothschild
Copy link
Contributor

Maybe remove the "AND" ?

That works for me.

@DHaussermann
Copy link

Discuss with @aaronrothschild
In the interest of simplicity, this was the agreed upon solution
image

@DHaussermann DHaussermann added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Oct 8, 2021
@DHaussermann
Copy link

Thanks for the quick solution on the @hanzei please merge.

@hanzei hanzei merged commit b03d543 into master Oct 8, 2021
@hanzei hanzei deleted the MM-39133_new-skus branch October 8, 2021 13:50
hanzei added a commit that referenced this pull request Oct 8, 2021
@hanzei
[MM-39133] Update Marketplace labels for new SKUs (#224)
9735836
@hanzei hanzei mentioned this pull request Oct 8, 2021
Merged
cpoile added a commit that referenced this pull request Mar 15, 2023
@cpoile @hanzei
@lieut-data @crspeller @larkox @agarciamontoro @mickmister @justinegeffen @jasonblais
MM-49610 - Merge master into production (#337)
48d943e 
* Programmatically add labels (#137)

* Add notice about Looker to plugin checklist (#151)

* Add Experimental and Partner label (#145)

* Add experimental and partner label

* Update generator add

* Apply labels before sending a response

* [MM-32593] Update golangci-lint to v1.33.2 (#165)

* [MM-32278] Change "E20 Only" tag on listings to "E20 and Cloud" (#161)

* Change EE label name (#168)

* [MM-33116] Use embed package to include Marketplace plugin list for lambda (#170)

* Merge production into master (#184)

Co-authored-by: Ben Schumacher <ben.schumacher@mattermost.com>
Co-authored-by: Jesse Hallam <jesse.hallam@gmail.com>
Co-authored-by: Christopher Speller <crspeller@gmail.com>
Co-authored-by: Daniel Espino García <larkox@gmail.com>
Co-authored-by: Alejandro García Montoro <alejandro.garciamontoro@gmail.com>
Co-authored-by: Christopher Poile <cpoile@gmail.com>
Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com>

* Update add_plugin.md

* Update add_plugin.md

* Update add_plugin.md

* [MM-39133] Update Marketplace labels for new SKUs (#224)

* Update add_plugin.md

* Update add_plugin.md

* Update icon URL from mattermost.org to mattermost.com (#269)

* change "Enterprise and Cloud" to "Professional/Enterprise"

* gofmt

* Change "license to run" to "subscription"

Co-authored-by: Jason Blais <13119842+jasonblais@users.noreply.github.com>

* Use mattermost-server/v6 (#283)

* Correctly set ReturnAllVersions and PluginID for upstream requests (#268)

* MM-49609 - Update mattermost-server version (#333)

* update mattermost-server version

* remove ioutil

* remove deprecated linters, add revive

* experimenting with go and node circleci upgrades

* fix

* fix

* go 1.19, revive, fix new linter errors

* fix golangci-lint-version to match dep orb

* fix comment

* use same golangci-lint as plugins

* fix failing build?

* testing...

* remove unneeded gotest/tools

* fix

* commit the plugins.json differences now, so next update doesn't have to

* MM-50203 - Update serverless (#338)

* Allow adding plugins with an invalid manifest to the Marketplace (#340)

* Downgrade node version to 12 (#343)

* Always pull tags from master (#344)

---------

Co-authored-by: Ben Schumacher <ben.schumacher@mattermost.com>
Co-authored-by: Jesse Hallam <jesse.hallam@gmail.com>
Co-authored-by: Christopher Speller <crspeller@gmail.com>
Co-authored-by: Daniel Espino García <larkox@gmail.com>
Co-authored-by: Alejandro García Montoro <alejandro.garciamontoro@gmail.com>
Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com>
Co-authored-by: Justine Geffen <justinegeffen@users.noreply.github.com>
Co-authored-by: Michael Kochell <mjkochell@gmail.com>
Co-authored-by: Jason Blais <13119842+jasonblais@users.noreply.github.com>
lieut-data added a commit that referenced this pull request Dec 8, 2023
@lieut-data @justinegeffen
@hanzei @mickmister @jasonblais @cpoile @mvitale1989
Update private beta (#402)
3140493 
* Update add_plugin.md

* Update add_plugin.md

* Update add_plugin.md

* [MM-39133] Update Marketplace labels for new SKUs (#224)

* Update add_plugin.md

* Update add_plugin.md

* Update icon URL from mattermost.org to mattermost.com (#269)

* change "Enterprise and Cloud" to "Professional/Enterprise"

* gofmt

* Change "license to run" to "subscription"

Co-authored-by: Jason Blais <13119842+jasonblais@users.noreply.github.com>

* Use mattermost-server/v6 (#283)

* Correctly set ReturnAllVersions and PluginID for upstream requests (#268)

* MM-49609 - Update mattermost-server version (#333)

* update mattermost-server version

* remove ioutil

* remove deprecated linters, add revive

* experimenting with go and node circleci upgrades

* fix

* fix

* go 1.19, revive, fix new linter errors

* fix golangci-lint-version to match dep orb

* fix comment

* use same golangci-lint as plugins

* fix failing build?

* testing...

* remove unneeded gotest/tools

* fix

* MM-50203 - Update serverless (#338)

* Allow adding plugins with an invalid manifest to the Marketplace (#340)

* Downgrade node version to 12 (#343)

* Always pull tags from master (#344)

* use underscore to convey unused variable (#360)

* Migrate to GHA: implement build jop

* Fix GHA workflow

* Fix workflow file

* Fix workflow: ensure local master branch exists

* Fix workflow file: only persist build artifacts

* Debug workflow file

* Fix node image permissions

* Add conditions to workflow steps

* Fix deploy job conditions

* Optimize workflow conditionals

* Remove double newline

* Debug serverless command availability

* Remove safety echo for actual deploys

* Emulate master merge to trigger a staging env deploy

* Debug ref name for push event

* Fix deploy conditions

* Debug deploy dir content

* Use node 12

* Bump node and serverless versions

* Restore corretct deploy condition

* Add uncommitted changes check step

* Fix typo

* Check for master branch existence before creating it

* Clean up command output

* CLD-6708 Increase serverless verbosity, persist lambda artifact (#401)

Increase serverless verbosity, persist lambda artifact

* simplify setting BUILD_UPSTREAM_URL via CI env: directive

---------

Co-authored-by: Justine Geffen <justinegeffen@users.noreply.github.com>
Co-authored-by: Ben Schumacher <ben.schumacher@mattermost.com>
Co-authored-by: Michael Kochell <mjkochell@gmail.com>
Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com>
Co-authored-by: Jason Blais <13119842+jasonblais@users.noreply.github.com>
Co-authored-by: Christopher Poile <cpoile@gmail.com>
Co-authored-by: Mario Vitale <mvitale1989@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHaussermann DHaussermann DHaussermann approved these changes

@catalintomai catalintomai catalintomai approved these changes

@aaronrothschild aaronrothschild Awaiting requested review from aaronrothschild

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hanzei @DHaussermann @catalintomai @aaronrothschild