-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MM-49610 - Merge master into production #337
Conversation
* Add experimental and partner label * Update generator add * Apply labels before sending a response
Co-authored-by: Ben Schumacher <ben.schumacher@mattermost.com> Co-authored-by: Jesse Hallam <jesse.hallam@gmail.com> Co-authored-by: Christopher Speller <crspeller@gmail.com> Co-authored-by: Daniel Espino García <larkox@gmail.com> Co-authored-by: Alejandro García Montoro <alejandro.garciamontoro@gmail.com> Co-authored-by: Christopher Poile <cpoile@gmail.com> Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com>
Update add_plugin.md
Co-authored-by: Jason Blais <13119842+jasonblais@users.noreply.github.com>
* update mattermost-server version * remove ioutil * remove deprecated linters, add revive * experimenting with go and node circleci upgrades * fix * fix * go 1.19, revive, fix new linter errors * fix golangci-lint-version to match dep orb * fix comment * use same golangci-lint as plugins * fix failing build? * testing... * remove unneeded gotest/tools * fix
# Conflicts: # .circleci/config.yml # go.mod # go.sum # internal/model/label.go # plugins.json
@cpoile Would you please merge |
@hanzei done |
@DHaussermann Could you please done some smoke testing around the Marketplace to ensure nothing breaks with this update? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍
Gentle ping on this @DHaussermann, thank you! |
Sorry for the delay on this @cpoile I can make time to test this today or Monday. Can you clarify the scope and expected behavior here? I can regression test that Calls is installable. But, the rest of the scope is unclear to me. Please let me know if you can provide some high level test guidance. |
@DHaussermann No worries. From my point of view, I think we just need to test that the production marketplace will still work after this merge. The updates to model allows us to generate the @hanzei Do you have anything specific you'd like to see tested? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and passed
- Can use Marketplace to install Calls
- Can use Marketplace to upgrade Calls from an earlier version
- Tested that hosting is still respected ex: Antivirus is not listed if licence is of type Cloud
- Tested that SKU for Proffesional/Enterprise check is still respected
- Other various regression testing (searching, installs, theming and labels, surfacing an error if the plugin cannot start etc...)
LGTM!
Thanks @DHaussermann for the work! |
Summary
plugins.json
diff ea51c3ehosting
field). This way the next person to run the generator won't see all this in their diff.Ticket Link