Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notice about Looker to plugin checklist #151

Merged
merged 2 commits into from
Jan 13, 2021
Merged

Add notice about Looker to plugin checklist #151

merged 2 commits into from
Jan 13, 2021

Conversation

hanzei
Copy link
Collaborator

@hanzei hanzei commented Dec 3, 2020

Summary

New plugins should get added to Looker so we can track there telemetry. This PR adds a step to the release checklist to ensure this gets done.

Ticket Link

None

@hanzei hanzei added the 2: Dev Review Requires review by a core committer label Dec 3, 2020
Copy link

@enelson720 enelson720 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hanzei
Copy link
Collaborator Author

hanzei commented Jan 13, 2021

/update-branch

@hanzei hanzei merged commit d9650fd into master Jan 13, 2021
@hanzei hanzei deleted the looker branch January 13, 2021 14:09
@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Jan 13, 2021
cpoile added a commit that referenced this pull request Mar 15, 2023
* Programmatically add labels (#137)

* Add notice about Looker to plugin checklist (#151)

* Add Experimental and Partner label (#145)

* Add experimental and partner label

* Update generator add

* Apply labels before sending a response

* [MM-32593] Update golangci-lint to v1.33.2 (#165)

* [MM-32278] Change "E20 Only" tag on listings to "E20 and Cloud" (#161)

* Change EE label name (#168)

* [MM-33116] Use embed package to include Marketplace plugin list for lambda (#170)

* Merge production into master (#184)

Co-authored-by: Ben Schumacher <ben.schumacher@mattermost.com>
Co-authored-by: Jesse Hallam <jesse.hallam@gmail.com>
Co-authored-by: Christopher Speller <crspeller@gmail.com>
Co-authored-by: Daniel Espino García <larkox@gmail.com>
Co-authored-by: Alejandro García Montoro <alejandro.garciamontoro@gmail.com>
Co-authored-by: Christopher Poile <cpoile@gmail.com>
Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com>

* Update add_plugin.md

* Update add_plugin.md

* Update add_plugin.md

* [MM-39133] Update Marketplace labels for new SKUs (#224)

* Update add_plugin.md

* Update add_plugin.md

* Update icon URL from mattermost.org to mattermost.com (#269)

* change "Enterprise and Cloud" to "Professional/Enterprise"

* gofmt

* Change "license to run" to "subscription"

Co-authored-by: Jason Blais <13119842+jasonblais@users.noreply.github.com>

* Use mattermost-server/v6 (#283)

* Correctly set ReturnAllVersions and PluginID for upstream requests (#268)

* MM-49609 - Update mattermost-server version (#333)

* update mattermost-server version

* remove ioutil

* remove deprecated linters, add revive

* experimenting with go and node circleci upgrades

* fix

* fix

* go 1.19, revive, fix new linter errors

* fix golangci-lint-version to match dep orb

* fix comment

* use same golangci-lint as plugins

* fix failing build?

* testing...

* remove unneeded gotest/tools

* fix

* commit the plugins.json differences now, so next update doesn't have to

* MM-50203 - Update serverless (#338)

* Allow adding plugins with an invalid manifest to the Marketplace (#340)

* Downgrade node version to 12 (#343)

* Always pull tags from master (#344)

---------

Co-authored-by: Ben Schumacher <ben.schumacher@mattermost.com>
Co-authored-by: Jesse Hallam <jesse.hallam@gmail.com>
Co-authored-by: Christopher Speller <crspeller@gmail.com>
Co-authored-by: Daniel Espino García <larkox@gmail.com>
Co-authored-by: Alejandro García Montoro <alejandro.garciamontoro@gmail.com>
Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com>
Co-authored-by: Justine Geffen <justinegeffen@users.noreply.github.com>
Co-authored-by: Michael Kochell <mjkochell@gmail.com>
Co-authored-by: Jason Blais <13119842+jasonblais@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants