MM-34585 Use removeClippedSubviews from Lists to improve scroll perf #5199

enahum · 2021-03-01T19:01:34Z

Summary

A few users have reported that in some android devices (Samsung with OneUI 3+) the app runs at low fps, this seems to be related with screens that are capable to have a higher refresh rate. Following the RN docs we are now using removeClippedSubviews to help improve the scrolling perf.

Ticket Link

Resolves: #5046
https://mattermost.atlassian.net/browse/MM-34585

mattermod · 2021-03-01T19:03:25Z

Building app in separate branch.

mattermod · 2021-03-01T19:10:05Z

Successfully building:
https://circleci.com/gh/mattermost/mattermost-mobile/14111
https://circleci.com/gh/mattermost/mattermost-mobile/14110

mattermod · 2021-03-01T19:25:06Z

Artifact links:
https://14111-70265724-gh.circle-artifacts.com/0/tmp/artifacts/Mattermost_Beta.apk
https://14110-70265724-gh.circle-artifacts.com/0/tmp/artifacts/Mattermost_Beta.ipa

migbot · 2021-03-01T19:57:44Z

android/app/src/main/java/com/mattermost/rnbeta/MainActivity.java

+            Float refreshRate = (Float)stringObjectHashMap.getOrDefault("refreshRate", 0f);
+            if (!seen || Math.round(refreshRate) == 60) {
+                seen = true;
+                best = stringObjectHashMap;


You can just break out of the for loop after setting best.

android/app/src/main/java/com/mattermost/rnbeta/MainActivity.java

app/utils/images.js

migbot · 2021-03-01T20:02:41Z

.circleci/config.yml

@@ -550,14 +550,14 @@ workflows:
            - test
          filters:
            branches:
-              only: /^build-pr-.*/
+              only: /^(build|android)-pr-.*/


Would this PR be reverted at some point? If so, consider having these changes in a separate PR?

I would like to keep this, that way if a PR fails for a particular platform we can just build the platform that we need

Oh yea, I meant that this specific change can be in a separate PR if you foresee the FPS changes being reverted in the future?

josephbaylon

LGTM. I don't have similar devices as found in the original issue and I can't find a hardware profile online to emulate. I just did a smoke test on a Pixel 3 XL (Android 11) devices and I don't experience sluggishness. Navigation, interaction with components, posting messages, switching channels and teams, searching, etc all seem to be functioning well.

Let me know if there's specific areas I need to test more.

enahum · 2021-03-02T16:12:40Z

@josephbaylon people over here #5046 can share more data points

shaz-r · 2021-03-03T11:29:10Z

I've got a Note 20 that I'm experimenting with - I don't think this PR has fixed the issue; unsure of what the cause is.

enahum · 2021-03-03T11:31:45Z

@SHAZM you and I should work together on this one, perhaps friday or over the weekend

mattermod · 2021-03-31T23:39:39Z

Building app in separate branch.

mattermod · 2021-03-31T23:45:20Z

Successfully building:
https://circleci.com/gh/mattermost/mattermost-mobile/14755
https://circleci.com/gh/mattermost/mattermost-mobile/14754

mattermod · 2021-03-31T23:59:21Z

Artifact links:
https://14755-70265724-gh.circle-artifacts.com/0/tmp/artifacts/Mattermost_Beta.ipa
https://14754-70265724-gh.circle-artifacts.com/0/tmp/artifacts/Mattermost_Beta.apk

josephbaylon

I retested on a Pixel 3 XL (Android 11) device and I'm not experiencing sluggishness. Scrolling, navigation, interaction with components, posting messages, switching channels and teams, searching, etc all seem to be functioning well.

@SHAZM has the device where he can repro the original issue. I'll wait for his testing before I approve the PR.

svelle

Tested on my Pixel 5. Showed some improvements. Performance graph showed less extreme spikes when movement was happening on the screen. Still room for improvement but a good start.

enahum · 2021-04-08T20:52:15Z

Spoke with @SHAZM this is OK to merge

mattermod · 2021-04-08T20:52:25Z

Cherry pick is scheduled.

…attermost#5199) (cherry picked from commit 9c043f1)

…5199) (#5298) (cherry picked from commit 9c043f1) Co-authored-by: Elias Nahum <nahumhbl@gmail.com>

enahum added 3 commits March 1, 2021 08:57

android: Set the app to run at the highest available fps

6ad405e

Trigger Android & iOS independent Pr builds

28d7d1c

Force Android to run at 60fps

6b6e7da

enahum added 2: Dev Review Requires review by a core commiter CherryPick/Candidate A candidate for a quality or patch release, but not yet approved 3: QA Review Requires review by a QA tester labels Mar 1, 2021

enahum added this to the v1.41.0 milestone Mar 1, 2021

enahum requested review from shaz-r, josephbaylon and migbot March 1, 2021 19:01

enahum added the Build Apps for PR Build the mobile app for iOS and Android to test label Mar 1, 2021

mattermod removed the Build Apps for PR Build the mobile app for iOS and Android to test label Mar 1, 2021

enahum mentioned this pull request Mar 1, 2021

App is low on fps on new upgrade to android 11 #5046

Closed

migbot reviewed Mar 1, 2021

View reviewed changes

josephbaylon approved these changes Mar 2, 2021

View reviewed changes

josephbaylon removed the 3: QA Review Requires review by a QA tester label Mar 2, 2021

josephbaylon self-requested a review March 2, 2021 16:42

josephbaylon added the 3: QA Review Requires review by a QA tester label Mar 2, 2021

amyblais removed this from the v1.41.0 milestone Mar 8, 2021

josephbaylon requested review from josephbaylon and removed request for josephbaylon March 29, 2021 23:00

enahum added 2 commits March 31, 2021 19:13

Merge branch 'master' into fps

82a82db

Use removeClippedSubviews from Lists to improve scroll perf

f1c97ad

enahum changed the title ~~Force Android to run the app at 60 fps~~ Use removeClippedSubviews from Lists to improve scroll perf Mar 31, 2021

enahum requested review from svelle and migbot March 31, 2021 22:57

enahum added this to the v1.42.0 milestone Mar 31, 2021

enahum added CherryPick/Approved Meant for the quality or patch release tracked in the milestone and removed CherryPick/Candidate A candidate for a quality or patch release, but not yet approved labels Mar 31, 2021

migbot approved these changes Mar 31, 2021

View reviewed changes

enahum added the Build Apps for PR Build the mobile app for iOS and Android to test label Mar 31, 2021

mattermod removed the Build Apps for PR Build the mobile app for iOS and Android to test label Mar 31, 2021

josephbaylon reviewed Apr 1, 2021

View reviewed changes

josephbaylon changed the title ~~Use removeClippedSubviews from Lists to improve scroll perf~~ MM-34585 Use removeClippedSubviews from Lists to improve scroll perf Apr 2, 2021

svelle approved these changes Apr 6, 2021

View reviewed changes

enahum removed the 3: QA Review Requires review by a QA tester label Apr 6, 2021

josephbaylon assigned shaz-r Apr 7, 2021

enahum unassigned shaz-r Apr 8, 2021

enahum removed the request for review from shaz-r April 8, 2021 20:51

enahum added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels Apr 8, 2021

enahum merged commit 9c043f1 into master Apr 8, 2021

enahum deleted the fps branch April 8, 2021 20:52

mattermost-build pushed a commit to mattermost-build/mattermost-mobile that referenced this pull request Apr 8, 2021

MM-34585 Use removeClippedSubviews from Lists to improve scroll perf (m…

f7c92c6

…attermost#5199) (cherry picked from commit 9c043f1)

mattermost-build mentioned this pull request Apr 8, 2021

Automated cherry pick of #5199 #5298

Merged

mattermod added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Apr 8, 2021

enahum added a commit that referenced this pull request Apr 10, 2021

MM-34585 Use removeClippedSubviews from Lists to improve scroll perf (#…

95e0e45

…5199) (#5298) (cherry picked from commit 9c043f1) Co-authored-by: Elias Nahum <nahumhbl@gmail.com>

enahum mentioned this pull request Apr 15, 2021

MM-34585 Fix at_mention and channel_mention autocomplete on iOS #5327

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MM-34585 Use removeClippedSubviews from Lists to improve scroll perf #5199

MM-34585 Use removeClippedSubviews from Lists to improve scroll perf #5199

enahum commented Mar 1, 2021 •

edited by josephbaylon

Loading

mattermod commented Mar 1, 2021

mattermod commented Mar 1, 2021

mattermod commented Mar 1, 2021

migbot Mar 1, 2021

migbot Mar 1, 2021

enahum Mar 1, 2021

migbot Mar 2, 2021

enahum Mar 2, 2021

josephbaylon left a comment

enahum commented Mar 2, 2021

shaz-r commented Mar 3, 2021

enahum commented Mar 3, 2021

mattermod commented Mar 31, 2021

mattermod commented Mar 31, 2021

mattermod commented Mar 31, 2021

josephbaylon left a comment •

edited

Loading

svelle left a comment

enahum commented Apr 8, 2021

mattermod commented Apr 8, 2021

MM-34585 Use removeClippedSubviews from Lists to improve scroll perf #5199

MM-34585 Use removeClippedSubviews from Lists to improve scroll perf #5199

Conversation

enahum commented Mar 1, 2021 • edited by josephbaylon Loading

Summary

Ticket Link

mattermod commented Mar 1, 2021

mattermod commented Mar 1, 2021

mattermod commented Mar 1, 2021

migbot Mar 1, 2021

Choose a reason for hiding this comment

migbot Mar 1, 2021

Choose a reason for hiding this comment

enahum Mar 1, 2021

Choose a reason for hiding this comment

migbot Mar 2, 2021

Choose a reason for hiding this comment

enahum Mar 2, 2021

Choose a reason for hiding this comment

josephbaylon left a comment

Choose a reason for hiding this comment

enahum commented Mar 2, 2021

shaz-r commented Mar 3, 2021

enahum commented Mar 3, 2021

mattermod commented Mar 31, 2021

mattermod commented Mar 31, 2021

mattermod commented Mar 31, 2021

josephbaylon left a comment • edited Loading

Choose a reason for hiding this comment

svelle left a comment

Choose a reason for hiding this comment

enahum commented Apr 8, 2021

mattermod commented Apr 8, 2021

enahum commented Mar 1, 2021 •

edited by josephbaylon

Loading

josephbaylon left a comment •

edited

Loading