MM-34585 Fix at_mention and channel_mention autocomplete on iOS #5327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enahum
added
2: Dev Review
josephbaylon
added
the
Build Apps for PR
|
Building app in separate branch. |
mattermod
removed
the
Build Apps for PR
josephbaylon
changed the title
migbot
approved these changes
Apr 15, 2021
josephbaylon
approved these changes
Apr 15, 2021
There was a problem hiding this comment.
LGTM. Was able to repro the issue on iOS. Verified issue is fixed with this PR. User can now scroll through the at-mention and channel-mention pop modal and tap on users and channels in multi section lists. Also tested Android and autocomplete still works there.
Tested on both iPhone X and Pixel 4 XL devices.
josephbaylon
added
4: Reviews Complete
|
Cherry pick is scheduled. |
mattermost-build
pushed a commit
to mattermost-build/mattermost-mobile
that referenced
this pull request
Apr 15, 2021
(cherry picked from commit c9a02d5)
mattermod
added
CherryPick/Done
migbot
pushed a commit
that referenced
this pull request
Apr 15, 2021
chetanyakan
pushed a commit
to brightscout-alpha/mattermost-mobile
that referenced
this pull request
Apr 16, 2021
… custom-status * 'master' of github.com:mattermost/mattermost-mobile: Bump app build number to 353 (mattermost#5331) MM-30429 Detox/E2E: Added e2e for MM-T3190, MM-T3212, MM-T3214, MM-T3227 (mattermost#5276) MM-27849 render emojis with appended skin tone (mattermost#5297) Fix at_mention and channel_mention autocomplete on iOS (mattermost#5327) Refactor rest client class to use mixin and a bit of cleanup (mattermost#5318) Bump app build number to 352 (mattermost#5324) Set url trailing slash (mattermost#5322) Use RNN 7.11.3 (mattermost#5317) MM-30431 Detox/E2E: Added e2e for MM-T3196, MM-T3210, MM-T3211, MM-T3262, MM-T3264 (mattermost#5313) Bump app build number to 351 (mattermost#5309) Translations update from Weblate (mattermost#5307)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After the introduction of #5199 the autocomplete for user and channel mentions that uses a SectionList were not working properly when displaying multiple sections, not allowing the user to tap on a result or scroll the list.
By setting the
removeSubclipViewsto false on iOS the issue is resolved, Android still applies the prop and works as expected.