Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations update from Mattermost Weblate #794

Closed
wants to merge 7 commits into from

Conversation

weblate
Copy link
Contributor

@weblate weblate commented Jun 24, 2024

Translations update from Mattermost Weblate for Calls/webapp.

Current translation status:

Weblate translation status

master7 and others added 6 commits June 20, 2024 06:47
Currently translated at 100.0% (221 of 221 strings)

Translation: Calls/webapp
Translate-URL: https://translate.mattermost.com/projects/calls/webapp/pl/
Currently translated at 100.0% (221 of 221 strings)

Translation: Calls/webapp
Translate-URL: https://translate.mattermost.com/projects/calls/webapp/de/
Currently translated at 100.0% (221 of 221 strings)

Translation: Calls/webapp
Translate-URL: https://translate.mattermost.com/projects/calls/webapp/nl/
Currently translated at 100.0% (221 of 221 strings)

Translation: Calls/webapp
Translate-URL: https://translate.mattermost.com/projects/calls/webapp/zh_Hans/
Copy link
Collaborator

@ctlaltdieliet ctlaltdieliet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@streamer45
Copy link
Collaborator

@toninis E2E pipeline is failing here but my expectation is that after #757 it should be working from forks. Thoughts?

@toninis toninis reopened this Jun 25, 2024
@toninis
Copy link
Contributor

toninis commented Jun 25, 2024

@streamer45 There are 2 failed tests for the e2e testing . I added the report summary as required in order to wait for the e2e tests upon PR .
In the meanwhile we can always make the status check success and judge on the failed tests if it's ok to merge .
WDYT ?

@streamer45
Copy link
Collaborator

@streamer45 There are 2 failed tests for the e2e testing . I added the report summary as required in order to wait for the e2e tests upon PR . In the meanwhile we can always make the status check success and judge on the failed tests if it's ok to merge . WDYT ?

@toninis Yeah, I'd prefer if we kept the ability to merge as sometimes we may have some flakiness or regressions on the web app side that have nothing to do with Calls.

@toninis
Copy link
Contributor

toninis commented Jun 25, 2024

Closing in favor of #797

@toninis toninis closed this Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants