Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MM-53944] Make use of github.com/mattermost/mattermost/server/public #163

Merged
merged 5 commits into from
Aug 22, 2023

Conversation

hanzei
Copy link
Contributor

@hanzei hanzei commented Aug 8, 2023

@hanzei hanzei added the 2: Dev Review Requires review by a core committer label Aug 8, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 8, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (b989a0d) 2.06% compared to head (fb8368d) 2.06%.

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #163      +/-   ##
=========================================
- Coverage    2.06%   2.06%   -0.01%     
=========================================
  Files          14      14              
  Lines        1741    1746       +5     
=========================================
  Hits           36      36              
- Misses       1703    1708       +5     
  Partials        2       2              
Files Changed Coverage Δ
server/activate_hooks.go 0.00% <0.00%> (ø)
server/channel_hooks.go 0.00% <ø> (ø)
server/command_hooks.go 0.00% <ø> (ø)
server/configuration.go 5.76% <ø> (ø)
server/file_hooks.go 0.00% <ø> (ø)
server/http_hooks.go 6.75% <ø> (ø)
server/job.go 0.00% <ø> (ø)
server/login_hooks.go 0.00% <ø> (ø)
server/main.go 0.00% <ø> (ø)
server/message_hooks.go 0.00% <ø> (ø)
... and 4 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@lieut-data lieut-data left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, @hanzei! Just one thought below :)

go.mod Outdated Show resolved Hide resolved
@hanzei hanzei added the Do Not Merge/Awaiting PR Awaiting another pull request before merging (e.g. server changes) label Aug 9, 2023
@hanzei hanzei removed the Do Not Merge/Awaiting PR Awaiting another pull request before merging (e.g. server changes) label Aug 21, 2023
@hanzei hanzei requested a review from cpoile August 22, 2023 07:23
@hanzei
Copy link
Contributor Author

hanzei commented Aug 22, 2023

@cpoile Would you mind giving this PR a review while @lieut-data is out?

Copy link
Member

@cpoile cpoile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Aug 22, 2023
@hanzei
Copy link
Contributor Author

hanzei commented Aug 22, 2023

I did some smoke testing and didn't run into issues. Merging 🚀

cc @DHaussermann

@hanzei hanzei added this to the v0.10.0 milestone Aug 22, 2023
@hanzei hanzei merged commit fef2202 into master Aug 22, 2023
4 checks passed
@hanzei hanzei deleted the MM-53944_use-public branch August 22, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants