-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MM-53944] Make use of github.com/mattermost/mattermost/server/public #393
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #393 +/- ##
=======================================
Coverage 32.93% 32.94%
=======================================
Files 22 22
Lines 4014 4013 -1
=======================================
Hits 1322 1322
+ Misses 2561 2560 -1
Partials 131 131
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@spirosoik Would you mind giving this PR a review so we can get it into 1.7.0? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hanzei overall looks good to me but I don't know what could be the impact of this change. may we need to include one more pair of eyes here. what do you think?
I did a smoke test of the change (compile the plugin, start it, and run a slash command). Is that enough? More complex issues might also be caught during release testing. |
Summary
This PR makes use of the newly created go module in https://pkg.go.dev/github.com/mattermost/mattermost/server/public.
See mattermost/mattermost-plugin-demo#163 for a similar migration.
Ticket Link
https://mattermost.atlassian.net/browse/MM-53944