Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MM-53944] Make use of github.com/mattermost/mattermost/server/public #393

Merged
merged 3 commits into from
Aug 23, 2023

Conversation

hanzei
Copy link
Collaborator

@hanzei hanzei commented Aug 21, 2023

Summary

This PR makes use of the newly created go module in https://pkg.go.dev/github.com/mattermost/mattermost/server/public.

See mattermost/mattermost-plugin-demo#163 for a similar migration.

Ticket Link

https://mattermost.atlassian.net/browse/MM-53944

@hanzei hanzei added the 2: Dev Review Requires review by a core committer label Aug 21, 2023
@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (8638c32) 32.93% compared to head (9db3b61) 32.94%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #393   +/-   ##
=======================================
  Coverage   32.93%   32.94%           
=======================================
  Files          22       22           
  Lines        4014     4013    -1     
=======================================
  Hits         1322     1322           
+ Misses       2561     2560    -1     
  Partials      131      131           
Files Changed Coverage Δ
server/api.go 21.17% <ø> (ø)
server/cluster.go 0.00% <ø> (ø)
server/command.go 24.27% <ø> (ø)
server/configuration.go 33.33% <ø> (ø)
server/flow.go 0.00% <ø> (ø)
server/main.go 0.00% <ø> (ø)
server/plugin.go 14.48% <ø> (ø)
server/telemetry.go 0.00% <ø> (ø)
server/webhook.go 40.30% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mickmister mickmister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hanzei hanzei added this to the v1.7.0 milestone Aug 22, 2023
@hanzei
Copy link
Collaborator Author

hanzei commented Aug 22, 2023

@spirosoik Would you mind giving this PR a review so we can get it into 1.7.0?

Copy link
Member

@spirosoik spirosoik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hanzei overall looks good to me but I don't know what could be the impact of this change. may we need to include one more pair of eyes here. what do you think?

@hanzei
Copy link
Collaborator Author

hanzei commented Aug 22, 2023

I did a smoke test of the change (compile the plugin, start it, and run a slash command). Is that enough? More complex issues might also be caught during release testing.

@hanzei hanzei modified the milestones: v1.7.0, v1.8.0 Aug 23, 2023
@hanzei hanzei requested a review from spirosoik August 23, 2023 07:13
@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Aug 23, 2023
@hanzei hanzei merged commit 835b440 into master Aug 23, 2023
9 checks passed
@hanzei hanzei deleted the MM-53944_use-public branch August 23, 2023 07:34
@avas27JTG avas27JTG mentioned this pull request Nov 29, 2023
@avas27JTG avas27JTG modified the milestones: v1.9.0, v1.8.0 Nov 29, 2023
@mickmister mickmister mentioned this pull request Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants