-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add UserHasBeenDeactivated hook to disconnect user #315
Conversation
Hello @MatthewDorner, Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here. |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #315 +/- ##
==========================================
- Coverage 32.94% 32.91% -0.04%
==========================================
Files 22 22
Lines 4013 4017 +4
==========================================
Hits 1322 1322
- Misses 2560 2564 +4
Partials 131 131
☔ View full report in Codecov by Sentry. |
This PR has been automatically labelled "stale" because it hasn't had recent activity. |
@mickmister @ashishbhate Updated here to match the updated plugin hook function signature in the server PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat 🎉
Note that this means we have to adjust this project's |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice 🎉
This PR has been automatically labelled "stale" because it hasn't had recent activity. |
@DHaussermann Gentle reminder to review this PR |
This PR has been automatically labelled "stale" because it hasn't had recent activity. |
/update-branch |
#393 needs to get merged first. |
Tested and confirmed that users who get deactivated also disconnect from GitLab. Ready for merging 🚀 |
Thanks, @MatthewDorner, for the contribution. Sorry, it took so long. |
Summary
Implement
UserHasBeenDeactivated
plugin hook to disconnect a user when that user is deactivated.Ticket Link
Fixes #287
Maybe obvious, but in order to test, you have add to the plugin's
go.mod
:replace github.com/mattermost/mattermost-server/v6 v6.5.0 => ../mattermost-server
to point to your local copy of server with the changes from my server PR: mattermost/mattermost#20894