-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MM-53944] Make use of github.com/mattermost/mattermost/server/public #163
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #163 +/- ##
=========================================
- Coverage 2.06% 2.06% -0.01%
=========================================
Files 14 14
Lines 1741 1746 +5
=========================================
Hits 36 36
- Misses 1703 1708 +5
Partials 2 2
☔ View full report in Codecov by Sentry. |
bb4a70b
to
7f122f2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, @hanzei! Just one thought below :)
@cpoile Would you mind giving this PR a review while @lieut-data is out? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
I did some smoke testing and didn't run into issues. Merging 🚀 |
Summary
This PR makes use of the newly created go module in https://pkg.go.dev/github.com/mattermost/mattermost/server/public.
It also sync the tooling with https://github.com/mattermost/mattermost-plugin-starter-template.
Ticket Link
https://mattermost.atlassian.net/browse/MM-53944