-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add user settings registry #172
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason I wasn't able to build the webapp part of the plugin, so I took the liberty to bump the dependencies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add the documentation in the webapp Readme of how this new registry would look like? here -> https://github.com/mattermost/mattermost-plugin-demo/tree/master/webapp#main-menu-action
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @larkox! Do we need to bump the min server version for support of this new registry? https://github.com/mattermost/mattermost-plugin-demo/blob/308bdd639fb46a97ab0487a69bf4260b6ae16127/plugin.json#L9C6-L9C24
@marianunez Not really. The code checks whether the registry exist, and use it if it exist, and doesn't use it if not. Therefore... the plugin can work with previous versions (it won't show the settings, thought). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #172 +/- ##
======================================
Coverage 3.10% 3.10%
======================================
Files 15 15
Lines 1869 1869
======================================
Hits 58 58
Misses 1809 1809
Partials 2 2 ☔ View full report in Codecov by Sentry. |
/update-branch |
Summary
Add user settings functionality to the demo plugin
Ticket Link
https://mattermost.atlassian.net/browse/MM-55755
Related to:
mattermost/mattermost#25517