Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user settings registry #172

Merged
merged 5 commits into from
Dec 19, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
16.13.1
18.18.2
Binary file added public/icon.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
22 changes: 6 additions & 16 deletions webapp/.eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"experimentalObjectRestSpread": true
}
},
"parser": "babel-eslint",
"parser": "@babel/eslint-parser",
"plugins": [
"react",
"import"
Expand All @@ -32,7 +32,10 @@
"beforeEach": true
},
"settings": {
"import/resolver": "webpack"
"import/resolver": "webpack",
"react": {
"version": "detect"
}
},
"rules": {
"array-bracket-spacing": [
Expand Down Expand Up @@ -374,14 +377,7 @@
"args": "after-used"
}
],
"no-use-before-define": [
2,
{
"classes": false,
"functions": false,
"variables": false
}
],
"no-use-before-define": "off",
"no-useless-computed-key": 2,
"no-useless-concat": 2,
"no-useless-constructor": 2,
Expand Down Expand Up @@ -655,12 +651,6 @@
"variables": false
}
],
"@typescript-eslint/camelcase": [
2,
{
"properties": "never"
}
],
"react/jsx-filename-extension": [
1,
{
Expand Down
8 changes: 8 additions & 0 deletions webapp/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -156,3 +156,11 @@ This plugin registers two custom routes.

- `/plug/com.mattermost.demo-plugin/roottest` which brings you to a page with the text `Demo plugin route.`
- `/<teamname>/com.mattermost.demo-plugin/teamtest` which brings you to a page with the text `Demo plugin team route.`

## User settings

This plugin registers three settings in two different sections.

![user-settings](docs/user_settings.png)

Upon saving the setting, the plugin is notified and alerts about the changes done.
Binary file added webapp/docs/user_settings.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading