-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MM-23227: preserve disable across config changes #93
MM-23227: preserve disable across config changes #93
Conversation
Fix an issue with how the configuration structure was always being reinitialized whenever a system configuration change occurred. Also avoid mutating the configuration in place. https://mattermost.atlassian.net/browse/MM-23227
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Looks like the CI is complaining about the coverage, but I don't understand why.
Oops, yeah -- looks like the tests were actually failing. Fixed! |
…isable-across-config-changes
Codecov Report
@@ Coverage Diff @@
## master #93 +/- ##
=========================================
+ Coverage 16.24% 17.64% +1.4%
=========================================
Files 13 13
Lines 1139 1139
=========================================
+ Hits 185 201 +16
+ Misses 916 900 -16
Partials 38 38
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and passed
I used the the user login event to be able to see when hooks are in fact disabled and confirmed I could repro the issue with previous release.
Tested and ensured that hooks now remain disabled when a new change is saved to the config.
Add a release test to cover this issue.
LGTM! Thanks @lieut-data for QA steps on this one.
Please merge.
Summary
Fix an issue with how the configuration structure was always being reinitialized whenever a system configuration change occurred. Also avoid mutating the configuration in place.
Note that the
go mod tidy
commit was run on vanilla master, not specifically my changes. Not sure how that slipped in.Ticket Link
https://mattermost.atlassian.net/browse/MM-23227