Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go mod tidy #98

Merged
merged 1 commit into from
Apr 3, 2020
Merged

go mod tidy #98

merged 1 commit into from
Apr 3, 2020

Conversation

hanzei
Copy link
Contributor

@hanzei hanzei commented Apr 3, 2020

Summary

Run go mod tidy

Ticket Link

Broken with #93

@hanzei hanzei added the 2: Dev Review Requires review by a core committer label Apr 3, 2020
@hanzei hanzei requested a review from lieut-data April 3, 2020 05:32
@codecov-io
Copy link

codecov-io commented Apr 3, 2020 •
edited
Loading

Codecov Report

Merging #98 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #98   +/-   ##
=======================================
  Coverage   17.47%   17.47%           
=======================================
  Files          13       13           
  Lines        1179     1179           
=======================================
  Hits          206      206           
  Misses        934      934           
  Partials       39       39

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5eff945...c87b23c. Read the comment docs.

@hanzei
Copy link
Contributor Author

hanzei commented Apr 3, 2020

Merging this with only one approval as it's blocking cutting a release

@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Apr 3, 2020
@hanzei hanzei added this to the v0.6.0 milestone Apr 3, 2020
@hanzei hanzei merged commit 3e731d5 into master Apr 3, 2020
@hanzei hanzei deleted the tidy branch April 3, 2020 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agnivade agnivade agnivade approved these changes

@lieut-data lieut-data Awaiting requested review from lieut-data

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
v0.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@hanzei @codecov-io @agnivade