Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter playbooks for LHS #1325

Merged
merged 2 commits into from
Jul 14, 2022
Merged

Filter playbooks for LHS #1325

merged 2 commits into from
Jul 14, 2022

Conversation

iomodo
Copy link
Contributor

@iomodo iomodo commented Jul 13, 2022

Summary

This PR fixes playbooks filter for LHS. See https://community.mattermost.com/core/pl/omaawaxwtfgf7eff55bunc7fic for details

Ticket Link

Checklist

  • Telemetry updated
  • Gated by experimental feature flag
  • Unit tests updated

@iomodo iomodo added the 2: Dev Review Requires review by a core committer label Jul 13, 2022
Copy link
Member

@crspeller crspeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we actually have to use the WithMembershipOnly option somewhere?

@iomodo iomodo requested a review from crspeller July 14, 2022 07:39
@crspeller crspeller merged commit 48fb57e into master Jul 14, 2022
@crspeller crspeller deleted the filter-playbooks branch July 14, 2022 14:28
trilopin added a commit that referenced this pull request Jul 14, 2022
* master:
  requested update timeline event (#1324)
  Filter playbooks for LHS (#1325)
  MM-45352: Run Details Page - RHS E2E (#1326)
  [MM-44755] Favoriting Playbooks (#1312)
trilopin added a commit that referenced this pull request Jul 15, 2022
* master: (74 commits)
  Fix category store (#1330)
  add 72px to avoid teambar (#1329)
  🎉 use new RDP/LHS by default 🎉  (#1322)
  MM-44754, MM-45087: Playbooks LHS Team Sidebar (#1327)
  [MM-45728] Favoriting runs (#1328)
  requested update timeline event (#1324)
  Filter playbooks for LHS (#1325)
  MM-45352: Run Details Page - RHS E2E (#1326)
  [MM-44755] Favoriting Playbooks (#1312)
  track role for playbookRun at server + new request-update/get-involved events (#1309)
  fix rhs issues (#1316)
  MM-45676: Increase margin between title and checklist box (#1320)
  fine tune run title control + toggle open in dotmenu (#1315)
  finish run to last pos + get involved modal + no-navigate (#1319)
  Make buttons non-editable for viewers (#1318)
  use followers noun to be consistent (#1323)
  MM-45575 Playbook member migration. (#1317)
  MM-44722: Checklist improvements (#1311)
  Rdp ux feedback batch (#1314)
  recover kebab and request update as participant (#1308)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2: Dev Review Requires review by a core committer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants