-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add 72px to avoid teambar in max-width calculations #1329
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an improvement, but I think we should do a bit more here overall (not now, but followup PRs). I have some doubts on using calcs in this way. A layout like this using grid or flex should be able to resize to it's container without having to use max-widths and such.
(these inspection helpers are really helpful for this sort of thing)
* master: (74 commits) Fix category store (#1330) add 72px to avoid teambar (#1329) 🎉 use new RDP/LHS by default 🎉 (#1322) MM-44754, MM-45087: Playbooks LHS Team Sidebar (#1327) [MM-45728] Favoriting runs (#1328) requested update timeline event (#1324) Filter playbooks for LHS (#1325) MM-45352: Run Details Page - RHS E2E (#1326) [MM-44755] Favoriting Playbooks (#1312) track role for playbookRun at server + new request-update/get-involved events (#1309) fix rhs issues (#1316) MM-45676: Increase margin between title and checklist box (#1320) fine tune run title control + toggle open in dotmenu (#1315) finish run to last pos + get involved modal + no-navigate (#1319) Make buttons non-editable for viewers (#1318) use followers noun to be consistent (#1323) MM-45575 Playbook member migration. (#1317) MM-44722: Checklist improvements (#1311) Rdp ux feedback batch (#1314) recover kebab and request update as participant (#1308) ...
Summary
Now we have team bar, we have to add 72px to our calculatios for max-width
Ticket Link
no ticket
Checklist
Telemetry updatedGated by experimental feature flagUnit tests updated