add 72px to avoid teambar in max-width calculations #1329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crspeller
approved these changes
Jul 14, 2022
calebroseland
approved these changes
Jul 14, 2022
There was a problem hiding this comment.
This is an improvement, but I think we should do a bit more here overall (not now, but followup PRs). I have some doubts on using calcs in this way. A layout like this using grid or flex should be able to resize to it's container without having to use max-widths and such.
(these inspection helpers are really helpful for this sort of thing)
Will check it out and you'll be the lucky reviewer |
trilopin
changed the title
trilopin
added
4: Reviews Complete
trilopin
added a commit
that referenced
this pull request
Jul 15, 2022
* master: (74 commits) Fix category store (#1330) add 72px to avoid teambar (#1329) 🎉 use new RDP/LHS by default 🎉 (#1322) MM-44754, MM-45087: Playbooks LHS Team Sidebar (#1327) [MM-45728] Favoriting runs (#1328) requested update timeline event (#1324) Filter playbooks for LHS (#1325) MM-45352: Run Details Page - RHS E2E (#1326) [MM-44755] Favoriting Playbooks (#1312) track role for playbookRun at server + new request-update/get-involved events (#1309) fix rhs issues (#1316) MM-45676: Increase margin between title and checklist box (#1320) fine tune run title control + toggle open in dotmenu (#1315) finish run to last pos + get involved modal + no-navigate (#1319) Make buttons non-editable for viewers (#1318) use followers noun to be consistent (#1323) MM-45575 Playbook member migration. (#1317) MM-44722: Checklist improvements (#1311) Rdp ux feedback batch (#1314) recover kebab and request update as participant (#1308) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Now we have team bar, we have to add 72px to our calculatios for max-width
Ticket Link
no ticket
Checklist
Telemetry updatedGated by experimental feature flagUnit tests updated