Append delocate version to wheel metadata #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After some consideration I want to rewrite this to not use |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #234 +/- ##
==========================================
+ Coverage 97.18% 97.25% +0.06%
==========================================
Files 16 16
Lines 1350 1348 -2
==========================================
- Hits 1312 1311 -1
+ Misses 38 37 -1 ☔ View full report in Codecov by Sentry. |
HexDecimal
force-pushed
the
wheel-metadata
branch
from
22d2211 to
ad8fa66
Compare
Refactor wheel record updater Using `delocate.__version__` would cause a cyclic import Importlib works better for type checkers Tests need to be changed to work with updated metadata Check for delocate generator header in tests Add to changelog
HexDecimal
force-pushed
the
wheel-metadata
branch
from
ad8fa66 to
82fc494
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the delocate version used to wheel metadata as suggested by the Binary distribution format guidelines. The format is
delocate {version}as shown in the guideline but I've seen other tools usename ({version})instead.Tagging wheels like this will help with future issues if there's ever a long term problem with a specific version of delocate.
There seemed to be cases where
rewrite_recordcould be called before modifications were done, this has been resolved.Was also able to move
.coveragercintopyproject.tomlso that's one less config file.Pull Request Checklist