Smarter detection of binary files during delocate-merge #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates merging to use `lipo` to detect binary files and removes the previous less reliable behavior. This handles the common case of binary files having no suffix. Reusing old tests instead of trying to keep the old behavior. Fuse wheels tests requires lipo
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #236 +/- ##
==========================================
- Coverage 97.18% 97.11% -0.07%
==========================================
Files 16 16
Lines 1350 1354 +4
==========================================
+ Hits 1312 1315 +3
- Misses 38 39 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates merging to automatically detect binary files and removes the older behavior. This handles the common case of binary files having no suffix. Fixes #228
Using
_is_macho_filehas false negatives. Instead, all files are passed to thelipocommand and its return code is used to determine if the file was valid to be merged. This might have it's own issues, but I'd need to completely rewritelipo_fuseto make it graceful.The
lib_extsparameter offuse_treesis now ignored and I intend for it to be removed completely later.This reuses old tests instead of trying to keep the old behavior. Updating the tests now could conflict with PR #234.
Pull Request Checklist