Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support a file that uses helmsman having an extension #3

Closed
beaugunderson opened this issue Aug 7, 2013 · 4 comments · Fixed by #6
Closed

Support a file that uses helmsman having an extension #3

beaugunderson opened this issue Aug 7, 2013 · 4 comments · Fixed by #6

Comments

@beaugunderson
Copy link
Collaborator

It looks like prefix gets set incorrectly if the main file using helmsman is named with an extension. For example, a file named projects.js gets a prefix of projects.js-, which is incorrect.

@mattmcmanus
Copy link
Owner

Gross! I'll fix that soon.

If you're feeling inspired, the code for that is here

@beaugunderson
Copy link
Collaborator Author

I've added fixes for the three issues I've created here in my fork:

https://github.com/beaugunderson/node-helmsman/compare/mattmcmanus:master...master?w=1

In addition to those changes I am also considering adding support for a non-require pattern, where you can specify the usage information in the main file (this will be useful for including commands of other languages, for example)... Is that something you're interested in?

@mattmcmanus
Copy link
Owner

Whoa! Awesome dude. All three issues taken care of AND fixing my spelling errors

If it is at all possible, could you open two separate pull requests? One for the file extension issues #3 & #4 and a separate one for the PATH + exports checking? The latter is a bigger shift from how things are now and I want to make sure to take the time to go through the changes there.

Thank you @beaugunderson. This is awesome work.

@beaugunderson
Copy link
Collaborator Author

Attempting to split up the changes now. :)

beaugunderson added a commit to beaugunderson/node-helmsman that referenced this issue Aug 22, 2013
beaugunderson added a commit to beaugunderson/node-helmsman that referenced this issue Aug 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants