-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support a file that uses helmsman having an extension #3
Comments
Gross! I'll fix that soon. If you're feeling inspired, the code for that is here |
I've added fixes for the three issues I've created here in my fork: https://github.com/beaugunderson/node-helmsman/compare/mattmcmanus:master...master?w=1 In addition to those changes I am also considering adding support for a non-require pattern, where you can specify the usage information in the main file (this will be useful for including commands of other languages, for example)... Is that something you're interested in? |
Whoa! Awesome dude. All three issues taken care of AND fixing my spelling errors If it is at all possible, could you open two separate pull requests? One for the file extension issues #3 & #4 and a separate one for the PATH + exports checking? The latter is a bigger shift from how things are now and I want to make sure to take the time to go through the changes there. Thank you @beaugunderson. This is awesome work. |
Attempting to split up the changes now. :) |
- Fixes mattmcmanus#3 - Fixes mattmcmanus#4
- Fixes mattmcmanus#3 - Fixes mattmcmanus#4
It looks like
prefix
gets set incorrectly if the main file using helmsman is named with an extension. For example, a file namedprojects.js
gets a prefix ofprojects.js-
, which is incorrect.The text was updated successfully, but these errors were encountered: