Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support command files having extensions #4

Closed
beaugunderson opened this issue Aug 7, 2013 · 2 comments · Fixed by #6
Closed

Support command files having extensions #4

beaugunderson opened this issue Aug 7, 2013 · 2 comments · Fixed by #6

Comments

@beaugunderson
Copy link
Collaborator

I have subcommands named <prefix>-<command>.js and helmsman includes the .js extension in the name of the command. It would be nice if it stripped the extension.

@beaugunderson
Copy link
Collaborator Author

Two reasons this would be nice:

  1. During development if you've symlinked your node module using npm link you'll get commands with extensions even if you've properly specified them in your package.json's bin hash without them.
  2. People may want to add their own commands (in their PATH, which is another issue I'll file separately) that have extensions

@mattmcmanus
Copy link
Owner

Good call. I simply haven't come across that yet.

When generating the list of commands it would be pretty trivial to wrap the commands in a path.basename(command, path.extname(command))

beaugunderson added a commit to beaugunderson/node-helmsman that referenced this issue Aug 22, 2013
beaugunderson added a commit to beaugunderson/node-helmsman that referenced this issue Aug 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants