Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chinese Translation Fixes #11936

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

gillamkid
Copy link
Contributor

@gillamkid gillamkid commented Sep 23, 2024

Fixes #11798

Description

Fixes issue repoerted here #11798
Need to use english comma "," instead of chinese comma "," for programatic parsing to work.

Sponsor

This contribution was sponsored by Firestorm
654d4f9476ff2a38f37e9ab9_firestorm-homepage-share-img-2

Before (errors in console)

before-chinese-comma

After (no errors)

after-chinese-comma

fixes mavlink#11798

Contribution Sponsor: Firestorm (launchfirestorm.com)
Contribution Sponsor: Firestorm (launchfirestorm.com)
@gillamkid gillamkid changed the title Fixes #11798 Chinese Translation Fixes Sep 23, 2024
@gillamkid
Copy link
Contributor Author

I couldn't figure out how to link my PR to the issue. Maybe I don't have enough permissions, because nothing instructed here worked for me: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue

@DonLakeFlyer
Copy link
Contributor

These need to be done through Crowdin not directly changed here. Then they come down automatically.

@DonLakeFlyer
Copy link
Contributor

@gillamkid
Copy link
Contributor Author

Oh ok, I requested edit permission on Crowdin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chinese Translation mark error 中文翻译符号错误
2 participants