Fix parsing longs and strings

[deathcap]

Includes several fixes:

• Updates jdataview to lowercase dependency name to fix missing dependency error (see https://www.npmjs.org/package/jDataView vs https://www.npmjs.org/package/jdataview)

• Uses getInt64 instead of getFloat64 to fix parsing TAG_Long – previously, would interpret the data as a float, leading to very small numbers:

  "firstPlayed": 6.75790774786e-312,

with jdataview 64-bit integers, split into two 32-bits:

"firstPlayed": {
  "lo": 2016155682,
  "hi": 318
},

which matches the value compared with NBTExplorer (318*Math.pow(2,32) + 2016155682 = 1367815755810):

• Parses strings as UTF-8 instead of 'binary':

parsed correctly as '§eElectric' (raw bytes: \xc2\xa7 utf8, decode as U+00A7). Before this would decode as '§eElectric'

---

P.S. @maxogden: any interest in merging this module with @sjmulder's https://github.com/sjmulder/nbt-js ('nbt' in npm)? It has been inactive (3 years) not sure if @sjmulder is still up for maintaining it but I think it has a cleaner implementation than this module ('minecraft-nbt'), written directly in JavaScript instead of updated translated from CoffeeScript; though it is using a bundled binary decoding library instead of jdataview. Would be cool to have one ultimate NBT library =) considering preserving the interface of minecraft-nbt (so minecraft-mca/region or any other users wouldn't have to change) but replacing the guts with 'nbt'. Maybe https://github.com/andrewrk/node-minecraft-protocol could even use it too? (cc @andrewrk @roblabla)

[max-mapper]

thanks for this! IMO the best way to do it today would be to write a new parsing using Buffer in Node, as it runs in all browsers now thanks to https://www.npmjs.org/package/buffer

[sjmulder]

Hey, it’s true that nbt.js hasn’t been getting much love since… years. I’m all up for fixing it up though, updating it to use newer libraries. It’s originally from the Node 0.4 era iirc, which is ancient.

[sjmulder]

In case you do ever intend to use nbt.js, I’ve just updated it to use Node’s Buffer API instead of the old bundled binary decoding library.