This repository has been archived by the owner on Mar 19, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bitwise operators unfortunately only operate on 32-bit integers, so x<<32 === x, and
is equivalent to upper + lower. For example this NBT file: https://github.com/deathcap/playerdat/blob/master/test.dat parses as:
This PR changes the calculation to:
so it can use the full range of 53-bit floating point, giving the correct value:
(cross checked with NBTExplorer and max-mapper/minecraft-nbt#2)
Precision loss can still occur (above 2^53 = 9007199254740992), so this doesn't fix GH-1 completely, but it takes care of some common cases.