ensure sessions are deleted when empty #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a session is empty it should be removed entirely.
Previously this was not the case as the modified flag cannot be set when
the underlying session data is empty. This makes sense because an empty
session should not be updated but instead deleted.
However, this also meant that removing the last key of a previously
stored session would not reflect this update in the store--the session
would not be saved to the store or deleted.
To address this, we now look for an empty session after resolving the
request. When found, we delete the session from the store and return the
response.
Fixes #21.
Codecov Report
@@ Coverage Diff @@
## main #22 +/- ##
==========================================
+ Coverage 77.96% 79.43% +1.47%
==========================================
Files 13 13
Lines 422 428 +6
==========================================
+ Hits 329 340 +11
+ Misses 93 88 -5
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a session is empty it should be removed entirely.
Previously this was not the case as the modified flag cannot be set when the underlying session data is empty. This makes sense because an empty session should not be updated but instead deleted.
However, this also meant that removing the last key of a previously stored session would not reflect this update in the store--the session would not be saved to the store or deleted.
To address this, we now look for an empty session after resolving the request. When found, we delete the session from the store and return the response.
Fixes #21.