Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensure sessions are deleted when empty #22

Merged
merged 2 commits into from
Oct 2, 2023
Merged

ensure sessions are deleted when empty #22

merged 2 commits into from
Oct 2, 2023

Commits on Oct 2, 2023

  1. ensure sessions are deleted when empty 

    When a session is empty it should be removed entirely.

Previously this was not the case as the modified flag cannot be set when
the underlying session data is empty. This makes sense because an empty
session should not be updated but instead deleted.

However, this also meant that removing the last key of a previously
stored session would not reflect this update in the store--the session
would not be saved to the store or deleted.

To address this, we now look for an empty session after resolving the
request. When found, we delete the session from the store and return the
response.

Fixes #21.
    @maxcountryman
    maxcountryman committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    82727e1 View commit details
    Browse the repository at this point in the history

  2. only call delete when a session is loaded from store

    @maxcountryman
    maxcountryman committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    aaad8da View commit details
    Browse the repository at this point in the history