-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Typing]: Correct typing for suppressing/forwarding contexts #143
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There was a recent update to the typing spec that codified the meaning of return types for (async) contexts:
-> bool
/-> Literal[True]
now mean the context may suppress exceptions, and any other annotations means exceptions are not suppressed. Notably, if a context does alwaysreturn False
in exit it should still not be-> bool
to indicate the exception propagates.At least one annotation is not correct with this scheme:
asyncstdlib/asyncstdlib/contextlib.py
Lines 202 to 204 in f9c80dd
The text was updated successfully, but these errors were encountered: