Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support targeting .NET Standard #136

Closed
wants to merge 1 commit into from

Conversation

bergbria
Copy link

Maintains support for .net 4.5 builds, adds .net standard 2.0 support

@bergbria
Copy link
Author

@maximn / others - I've converted the main library to .net standard and the tests to .net core 3.0. This all builds successfully but I don't really know how to update the github CI configuration. Any pointers?

@bergbria bergbria mentioned this pull request Nov 25, 2019
@maximn
Copy link
Owner

maximn commented Nov 25, 2019

@maximn
Copy link
Owner

maximn commented Nov 25, 2019

I think that we need to fix the tests on master first before changing.
It's a bit flaky and from time to time breaks becuase it's an integration with goole maps server. Can you have a look at that?

@derigel23
Copy link

@maximn any foreseeable plans to migrate library to .NET Core?

@maximn
Copy link
Owner

maximn commented Oct 2, 2021

@derigel23
Hi, I don't have Windows and not using .NET anymore.
Do you think that I can run .net core on my Mac?
Otherwise, if you're willing to contribute and fix I'll merge it.

@derigel23
Copy link

Yes, you definitely can run .NET Core on Mac.
And use free VS Code or trial JetBrains Rider as an IDE.
I'll try to look at and fix tests (as I understand it's a main blocker for merging this PR).

@maximn
Copy link
Owner

maximn commented Oct 9, 2021

I'm not available for this right now. I'll try to have a look on it in a few months.
If you have the time you're welcome to contribute and I'll merge it. Thanks!

@gguillen
Copy link
Contributor

gguillen commented Nov 1, 2021

I just submitted #144. It would be nice if I could get some more eyes on apis other than the geocoding ones.

@maximn maximn closed this Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants