Upgraded to .Net Core style project and added package build targets #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t standard 2.0, net framework 4.6.1
|
I only have a geocode key so I was not able to test the other API endpoints. If someone could confirm they work, should be good to go. I updated the ci file, but I am not familiar with it and it might not be right, but the tests pass in VS. |
|
Big thanks! I think that you can get a free api key here - https://console.cloud.google.com/google/maps-apis/overview |
|
@gguillen Hi, note that you've added your API key to the code of the project ... I would suggest to revoke it. |
|
Yea, I saw that right when I committed it so I rotated it. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgraded to .Net Core style project. Now supports .net 5, .net 6, .net standard 2.0, net framework 4.6.1.