Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev #1

Merged
merged 55 commits into from
Apr 12, 2019
Merged

Dev #1

merged 55 commits into from
Apr 12, 2019

Conversation

mayankchetan
Copy link
Owner

Complete this sentence
THIS PULL REQUEST __ [IS/IS NOT] __ READY TO MERGE

Feature or improvement description

A clear and concise description of the new code.

Related issue, if one exists

Link to a related GitHub Issue.

Impacted areas of the software

List any modules or other areas which should be impacted by this pull request. This helps to determine the verification tests.

Additional supporting information

Add any other context about the problem here.

Automated test results

Add the automated test results (unit tests and regression tests) here, if they've been run.
For any failing tests, please provide justification.

ebranlard and others added 30 commits February 7, 2019 16:31
* WaveMode was set to 0 instead of WaveDirMod (Fixes #246)
* Fix out-of-bounds memory access in C++ API

This pull request attempts to address the heap-buffer-overflow error
reported in Nalu-Wind nightly tests using LLVM address sanitizer. For
details see:

https://my.cdash.org/testDetails.php?test=45418647&build=1609666

* Fix out of bounds array access in the OpenFAST-CFD interface
This OOB error was reported in Nalu-Wind nightly testing by LLVM/Clang
address sanitizer:
https://my.cdash.org/testDetails.php?test=45554439&build=1613318

==17307==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x60300080c398 at pc 0x000000496f7f bp 0x7ffd323df520 sp 0x7ffd323decd0 READ of size 1025 at 0x60300080c398 thread T0
0x60300080c398 is located 0 bytes to the right of 24-byte region [0x60300080c380,0x60300080c398)

This issue was reported by Jon Rood. The fix implemented is similar to
the one discussed in #243.
Fix out-of-bounds array error in C++ API
…ocumentation with inclusion of an instruction to copy the r-test folder to build/reg_tests
Fixes #254 - Updates the testing documentation for Windows with instructions to copy r-test folder
Allowing number of Morison number to be 0 (see #79)
This will be covered in the FAST readme
rafmudaf and others added 19 commits March 19, 2019 11:50
There’s no need to use this specific Georgia Tech mirror as mirrors are, well … mirrors.
A few updates to the documentation
Sync the git versions for windows and linux builds
If an invalid channel name is selected, InflowWind uses a default index of 0. However, the `m%Allouts` array it was indexing into started with 1 instead of 0.
Fix InflowWind index for invalid channels + typo in HydroDyn echo file
Adding safety on number of lines and number of fields per line when WaveMode=6 (Should Fix #118)
…puts) (#265)

* Updated BD linearizaon perturbation precision

* updated error handling in static solve

* BD: fixed assumption about first-node relative rotation

* BD bug fix: point load array size with multiple elements

* BD bug fix: removed extra GlbRot transform on output QP loads

output forces -- removed extra GlbRot transform on output QP forces / moments

* BD bug fix: Updated integration of nodal output loads

New integration implemented by @andrew-platt.

* Fixes for multi-element load outputs at nodes

* clean up a few comments and modify some code logic to align with the dev branch after merge from Envision

* Merge conflict cleanup

* Update the BeamDyn reg test baselines

* Add more outputs in BeamDyn 5MW reg test case
This avoids rebuilding every source file when the git commit changes
Updated Visual Studio builds for Windows
@mayankchetan mayankchetan merged commit 19c378d into mayankchetan:dev Apr 12, 2019
mayankchetan pushed a commit that referenced this pull request Jan 25, 2022
* Update rules for Intel OneAPI compiler detection

CMake 3.20 differentiates between older Intel compilers and the Intel
OneAPI compilers (which is now detected as `IntelLLVM`). This commit
introduces the necessary changes to CMake logic to allow building using
OneAPI compiler stack with the latest CMake version.

* Update CMake check for Intel compiler (#1)

Co-authored-by: Rafael M Mudafort <rafael.mudafort@nrel.gov>
mayankchetan pushed a commit that referenced this pull request Jul 22, 2022
Move environment vars for HD init into InitInpType
mayankchetan pushed a commit that referenced this pull request Mar 3, 2023
More updates for new `DbKi=R8Ki` behavior
mayankchetan pushed a commit that referenced this pull request Jun 15, 2023
mayankchetan pushed a commit that referenced this pull request Jun 15, 2023
openfast(66108,0x10fb1edc0) malloc: *** error for object 0x7fe4a223a000: pointer being freed was not allocated
openfast(66108,0x10fb1edc0) malloc: *** set a breakpoint in malloc_error_break to debug

Program received signal SIGABRT: Process abort signal.

Backtrace for this error:
\#0  0x103a3f33d
\#1  0x103a3e76d
\#2  0x7fff68c225fc
Abort trap: 6
mayankchetan pushed a commit that referenced this pull request Jun 15, 2023
mayankchetan pushed a commit that referenced this pull request Nov 10, 2023
Update regression tests, and merge in latest rc-3.5.1
mayankchetan pushed a commit that referenced this pull request Apr 4, 2024
Automatically build OpenFAST docker images
mayankchetan pushed a commit that referenced this pull request Jul 24, 2024
MD: minor cleanup on Lin Damp feature
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants