Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.18.0.0 seems to cause misaligned sections #87

Open
mathstuf opened this issue Apr 24, 2023 · 5 comments
Open

0.18.0.0 seems to cause misaligned sections #87

mathstuf opened this issue Apr 24, 2023 · 5 comments

Comments

@mathstuf
Copy link

Our CI started failing today using the manylinux2014 image. Given the symptom and the dist-info diff of a single installation (A/D seems to be backwards from what I'd expect):

% podman diff 879520bd4b55f4db71fb325219fe390c487f3d5409c4f89ea4201bbc1d18dd5b 4901c60f84c46a321c15d5283ed541efcbcf8c566bfc0cb52171af4cfa800d11 | grep dist-info$ | grep 3.10
C /opt/_internal/cpython-3.10.11/lib/python3.10/site-packages/tomli-2.0.1.dist-info
C /opt/_internal/cpython-3.10.11/lib/python3.10/site-packages/pyproject_hooks-1.0.0.dist-info
C /opt/_internal/cpython-3.10.11/lib/python3.10/site-packages/build-0.10.0.dist-info
C /opt/_internal/cpython-3.10.11/lib/python3.10/site-packages/packaging-23.1.dist-info
A /opt/_internal/cpython-3.10.11/lib/python3.10/site-packages/pip-23.1.dist-info
C /opt/_internal/cpython-3.10.11/lib/python3.10/site-packages/wheel-0.40.0.dist-info
A /opt/_internal/cpython-3.10.11/lib/python3.10/site-packages/setuptools-67.6.1.dist-info
D /opt/_internal/cpython-3.10.11/lib/python3.10/site-packages/setuptools-67.7.1.dist-info
D /opt/_internal/cpython-3.10.11/lib/python3.10/site-packages/pip-23.1.1.dist-info
C /opt/_internal/tools/lib/python3.10/site-packages/build-0.10.0.dist-info
C /opt/_internal/tools/lib/python3.10/site-packages/pyproject_hooks-1.0.0.dist-info
A /opt/_internal/tools/lib/python3.10/site-packages/setuptools-67.6.1.dist-info
A /opt/_internal/tools/lib/python3.10/site-packages/pip-23.1.dist-info
C /opt/_internal/tools/lib/python3.10/site-packages/pipx-1.2.0.dist-info
C /opt/_internal/tools/lib/python3.10/site-packages/userpath-1.8.0.dist-info
A /opt/_internal/tools/lib/python3.10/site-packages/argcomplete-3.0.5.dist-info
C /opt/_internal/tools/lib/python3.10/site-packages/certifi-2022.12.7.dist-info
C /opt/_internal/tools/lib/python3.10/site-packages/click-8.1.3.dist-info
C /opt/_internal/tools/lib/python3.10/site-packages/packaging-23.1.dist-info
C /opt/_internal/tools/lib/python3.10/site-packages/tomli-2.0.1.dist-info
C /opt/_internal/tools/lib/python3.10/site-packages/wheel-0.40.0.dist-info
D /opt/_internal/tools/lib/python3.10/site-packages/pip-23.1.1.dist-info
D /opt/_internal/tools/lib/python3.10/site-packages/argcomplete-3.0.8.dist-info
D /opt/_internal/tools/lib/python3.10/site-packages/setuptools-67.7.1.dist-info
A /opt/_internal/pipx/shared/lib/python3.10/site-packages/pip-23.1.dist-info
A /opt/_internal/pipx/shared/lib/python3.10/site-packages/setuptools-67.6.1.dist-info
C /opt/_internal/pipx/shared/lib/python3.10/site-packages/wheel-0.40.0.dist-info
D /opt/_internal/pipx/shared/lib/python3.10/site-packages/setuptools-67.7.2.dist-info
D /opt/_internal/pipx/shared/lib/python3.10/site-packages/pip-23.1.1.dist-info
C /opt/_internal/pipx/venvs/auditwheel/lib/python3.10/site-packages/auditwheel-5.3.0.dist-info
C /opt/_internal/pipx/venvs/auditwheel/lib/python3.10/site-packages/pyelftools-0.29.dist-info
C /opt/_internal/pipx/venvs/cmake/lib/python3.10/site-packages/cmake-3.26.3.dist-info
A /opt/_internal/pipx/venvs/patchelf/lib/python3.10/site-packages/patchelf-0.17.2.1.dist-info
D /opt/_internal/pipx/venvs/patchelf/lib/python3.10/site-packages/patchelf-0.18.0.0.dist-info
C /opt/_internal/pipx/venvs/swig/lib/python3.10/site-packages/swig-4.1.1.dist-info

between these two containers:

Working: quay.io/pypa/manylinux2014_x86_64@sha256:bc1b92cee27af8cd949e6abb7036ec17e2ce66066a89131fdf6ec9212c6762e3
Broken : quay.io/pypa/manylinux2014_x86_64@sha256:d2e6fbda70ff201243e824a86b5ce3dc3f93fa56865d1d84a2a3ac0578c86826

our generated wheels now have the following error when trying to import our modules:

$ venv/bin/python -c "import vtk"
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/builds/gitlab-kitware-sciviz-ci/venv/lib/python3.10/site-packages/vtk.py", line 5, in <module>
    from vtkmodules.vtkWebCore import *
ImportError: libXcursor-1a09904e.so.1.0.2: ELF load command address/offset not properly aligned

Something seems to have broken this between 0.17.2.1 and 0.18.0.0.

@mathstuf
Copy link
Author

Looking at the logs…it's a bunch of CI chores and a submodule bump. Upstream issue: NixOS/patchelf#492

@SeanCurtis-TRI
Copy link

Looks like they're reverting.

@mayeut
Copy link
Owner

mayeut commented Apr 24, 2023

The 0.18.0.0 version has been yanked pending further investigation upstream.

@nv-kmcgill53
Copy link

Any updates on this? 0.18.0 is the current version defined in the apt repository for the LTS Ubuntu 24.04 version. Can this be updated to point at 0.17.2?

nv-kmcgill53 added a commit to triton-inference-server/server that referenced this issue Jan 21, 2025
…ession

Patchelf shipped a regression in 0.18.0 and has since yanked the pypi release pointing to
0.17.2 as the most recent version. However, 0.18.0 is still the version shipped in both the apt and yum
repositories, thus we must use pip to install the version we want.
See mayeut/patchelf-pypi#87
nv-kmcgill53 added a commit to triton-inference-server/server that referenced this issue Jan 21, 2025
…ession

Patchelf shipped a regression in 0.18.0 and has since yanked the pypi release pointing to
0.17.2 as the most recent version. However, 0.18.0 is still the version shipped in both the apt and yum
repositories, thus we must use pip to install the version we want.
See mayeut/patchelf-pypi#87
nv-kmcgill53 added a commit to triton-inference-server/pytorch_backend that referenced this issue Jan 21, 2025
…ession

    Patchelf shipped a regression in 0.18.0 and has since yanked the pypi release pointing to
    0.17.2 as the most recent version. However, 0.18.0 is still the version shipped in both the apt and yum
    repositories, thus we must use pip to install the version we want.
    See mayeut/patchelf-pypi#87
nv-kmcgill53 added a commit to triton-inference-server/openvino_backend that referenced this issue Jan 21, 2025
…ession

Patchelf shipped a regression in 0.18.0 and has since yanked the pypi release pointing to
0.17.2 as the most recent version. However, 0.18.0 is still the version shipped in both the apt and yum
repositories, thus we must use pip to install the version we want.
See mayeut/patchelf-pypi#87
nv-kmcgill53 added a commit to triton-inference-server/onnxruntime_backend that referenced this issue Jan 21, 2025
…ession

Patchelf shipped a regression in 0.18.0 and has since yanked the pypi release pointing to
0.17.2 as the most recent version. However, 0.18.0 is still the version shipped in both the apt and yum
repositories, thus we must use pip to install the version we want.
See mayeut/patchelf-pypi#87
nv-kmcgill53 added a commit to triton-inference-server/tensorflow_backend that referenced this issue Jan 21, 2025
…ession

Patchelf shipped a regression in 0.18.0 and has since yanked the pypi release pointing to
0.17.2 as the most recent version. However, 0.18.0 is still the version shipped in both the apt and yum
repositories, thus we must use pip to install the version we want.
See mayeut/patchelf-pypi#87
nv-kmcgill53 added a commit to triton-inference-server/server that referenced this issue Jan 22, 2025
Co-authored-by: Ryan McCormick <rmccormick@nvidia.com>

Patchelf shipped a regression in 0.18.0 and has since yanked the pypi release pointing to
0.17.2 as the most recent version. However, 0.18.0 is still the version shipped in both the apt and yum
repositories, thus we must use pip to install the version we want.
See mayeut/patchelf-pypi#87
nv-kmcgill53 added a commit to triton-inference-server/pytorch_backend that referenced this issue Jan 22, 2025
…ession (#145)

Patchelf shipped a regression in 0.18.0 and has since yanked the pypi release pointing to
0.17.2 as the most recent version. However, 0.18.0 is still the version shipped in both the apt and yum
repositories, thus we must use pip to install the version we want.
See mayeut/patchelf-pypi#87
nv-kmcgill53 added a commit to triton-inference-server/openvino_backend that referenced this issue Jan 22, 2025
Downgrade patchelf version from 0.18.0 to 0.17.2 due to patchelf regression

Patchelf shipped a regression in 0.18.0 and has since yanked the pypi release pointing to
0.17.2 as the most recent version. However, 0.18.0 is still the version shipped in both the apt and yum
repositories, thus we must use pip to install the version we want.
See mayeut/patchelf-pypi#87
nv-kmcgill53 added a commit to triton-inference-server/onnxruntime_backend that referenced this issue Jan 22, 2025
Downgrade patchelf version from 0.18.0 to 0.17.2 due to patchelf regression

Patchelf shipped a regression in 0.18.0 and has since yanked the pypi release pointing to
0.17.2 as the most recent version. However, 0.18.0 is still the version shipped in both the apt and yum
repositories, thus we must use pip to install the version we want.
See mayeut/patchelf-pypi#87
nv-kmcgill53 added a commit to triton-inference-server/tensorflow_backend that referenced this issue Jan 22, 2025
…ession (#109)

Patchelf shipped a regression in 0.18.0 and has since yanked the pypi release pointing to
0.17.2 as the most recent version. However, 0.18.0 is still the version shipped in both the apt and yum
repositories, thus we must use pip to install the version we want.
See mayeut/patchelf-pypi#87
@mayeut
Copy link
Owner

mayeut commented Jan 26, 2025

Any updates on this? 0.18.0 is the current version defined in the apt repository for the LTS Ubuntu 24.04 version. Can this be updated to point at 0.17.2?

This repo just packages the upstream https://github.com/NixOS/patchelf for PyPI to allow pip/pipx/uv install.
This repo has nothing to do with what is being packaged in Ubuntu.

The 0.18.0 version is already yanked in PyPI.
We're waiting for a fix/new version upstream (NixOS/patchelf#492) to publish a new version.
There's nothing to do here for now.

mc-nv pushed a commit to triton-inference-server/onnxruntime_backend that referenced this issue Jan 31, 2025
Downgrade patchelf version from 0.18.0 to 0.17.2 due to patchelf regression

Patchelf shipped a regression in 0.18.0 and has since yanked the pypi release pointing to
0.17.2 as the most recent version. However, 0.18.0 is still the version shipped in both the apt and yum
repositories, thus we must use pip to install the version we want.
See mayeut/patchelf-pypi#87
mc-nv pushed a commit to triton-inference-server/openvino_backend that referenced this issue Jan 31, 2025
Downgrade patchelf version from 0.18.0 to 0.17.2 due to patchelf regression

Patchelf shipped a regression in 0.18.0 and has since yanked the pypi release pointing to
0.17.2 as the most recent version. However, 0.18.0 is still the version shipped in both the apt and yum
repositories, thus we must use pip to install the version we want.
See mayeut/patchelf-pypi#87
mc-nv pushed a commit to triton-inference-server/pytorch_backend that referenced this issue Jan 31, 2025
…ession (#145)

Patchelf shipped a regression in 0.18.0 and has since yanked the pypi release pointing to
0.17.2 as the most recent version. However, 0.18.0 is still the version shipped in both the apt and yum
repositories, thus we must use pip to install the version we want.
See mayeut/patchelf-pypi#87
mc-nv pushed a commit to triton-inference-server/tensorflow_backend that referenced this issue Jan 31, 2025
…ession (#109)

Patchelf shipped a regression in 0.18.0 and has since yanked the pypi release pointing to
0.17.2 as the most recent version. However, 0.18.0 is still the version shipped in both the apt and yum
repositories, thus we must use pip to install the version we want.
See mayeut/patchelf-pypi#87
mc-nv pushed a commit to triton-inference-server/server that referenced this issue Jan 31, 2025
Co-authored-by: Ryan McCormick <rmccormick@nvidia.com>

Patchelf shipped a regression in 0.18.0 and has since yanked the pypi release pointing to
0.17.2 as the most recent version. However, 0.18.0 is still the version shipped in both the apt and yum
repositories, thus we must use pip to install the version we want.
See mayeut/patchelf-pypi#87
mc-nv added a commit to triton-inference-server/tensorflow_backend that referenced this issue Feb 4, 2025
…ession (#109) (#110)

Patchelf shipped a regression in 0.18.0 and has since yanked the pypi release pointing to
0.17.2 as the most recent version. However, 0.18.0 is still the version shipped in both the apt and yum
repositories, thus we must use pip to install the version we want.
See mayeut/patchelf-pypi#87

Co-authored-by: Kyle McGill <101670481+nv-kmcgill53@users.noreply.github.com>
mc-nv added a commit to triton-inference-server/pytorch_backend that referenced this issue Feb 4, 2025
* Update the symlink (#144)

* Downgrade patchelf version from 0.18.0 to 0.17.2 due to patchelf regression (#145)

Patchelf shipped a regression in 0.18.0 and has since yanked the pypi release pointing to
0.17.2 as the most recent version. However, 0.18.0 is still the version shipped in both the apt and yum
repositories, thus we must use pip to install the version we want.
See mayeut/patchelf-pypi#87

---------

Co-authored-by: Pavithra Vijayakrishnan <160681768+pvijayakrish@users.noreply.github.com>
Co-authored-by: Kyle McGill <101670481+nv-kmcgill53@users.noreply.github.com>
mc-nv added a commit to triton-inference-server/openvino_backend that referenced this issue Feb 4, 2025
Downgrade patchelf version from 0.18.0 to 0.17.2 due to patchelf regression

Patchelf shipped a regression in 0.18.0 and has since yanked the pypi release pointing to
0.17.2 as the most recent version. However, 0.18.0 is still the version shipped in both the apt and yum
repositories, thus we must use pip to install the version we want.
See mayeut/patchelf-pypi#87

Co-authored-by: Kyle McGill <101670481+nv-kmcgill53@users.noreply.github.com>
mc-nv added a commit to triton-inference-server/onnxruntime_backend that referenced this issue Feb 4, 2025
* Update CUDA archs in ORT (#291)

* Update CUDA archs in ORT

* Update CUDA archs in ORT and fixing typo

* Update cudnn home

* Version upgrade for openvino updated from 24.12

* Update CUDNN_home for v9.7.0

* Update the home path

* Update path

* Update CUDNN home

* Remove comments

* Update the supported igpu NVCC

* Update the supported igpu and dgpu NVCC

* Upadate default branch post 24.12 (#290)

* Update README and versions for 2.53.0 / 24.12 (#288)

* Update 'gen_ort_dockerfile.py' fil to meet changes in ONNX Runtime 1.20.x

* remove psutils

* Update reformating

* restore description

* Update OpenVINO to 2024.5 (#287)

* Update 'gen_ort_dockerfile.py' fil to meet changes in ONNX Runtime 1.20.x

* remove psutils

* Add OpenVINO version

* Fix pre-commit issues

* Extract archive in different location (#289)

* Extract archive in different location

* Revert "Extract archive in different location"

This reverts commit e57256a.

* Update installation instructions

* Reapply "Extract archive in different location"

This reverts commit 59e24e4.

* Rolling back changes cherry picked from 24.12

* Rolling back changes cherry picked from 24.12: fixing spaces

---------

Co-authored-by: Misha Chornyi <99709299+mc-nv@users.noreply.github.com>

* Downgrade patchelf version from 0.18.0 to 0.17.2  (#295)

Downgrade patchelf version from 0.18.0 to 0.17.2 due to patchelf regression

Patchelf shipped a regression in 0.18.0 and has since yanked the pypi release pointing to
0.17.2 as the most recent version. However, 0.18.0 is still the version shipped in both the apt and yum
repositories, thus we must use pip to install the version we want.
See mayeut/patchelf-pypi#87

---------

Co-authored-by: Pavithra Vijayakrishnan <160681768+pvijayakrish@users.noreply.github.com>
Co-authored-by: Kyle McGill <101670481+nv-kmcgill53@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants