build: Downgrade patchelf version from 0.18.0 to 0.17.2 #7959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ession Patchelf shipped a regression in 0.18.0 and has since yanked the pypi release pointing to 0.17.2 as the most recent version. However, 0.18.0 is still the version shipped in both the apt and yum repositories, thus we must use pip to install the version we want. See mayeut/patchelf-pypi#87
nv-kmcgill53
added
the
PR: build
rmccorm4
reviewed
Jan 22, 2025
rmccorm4
reviewed
Jan 22, 2025
rmccorm4
approved these changes
Jan 22, 2025
rmccorm4
requested changes
Jan 22, 2025
Co-authored-by: Ryan McCormick <rmccormick@nvidia.com>
rmccorm4
approved these changes
Jan 22, 2025
mc-nv
pushed a commit
that referenced
this pull request
Jan 31, 2025
Co-authored-by: Ryan McCormick <rmccormick@nvidia.com> Patchelf shipped a regression in 0.18.0 and has since yanked the pypi release pointing to 0.17.2 as the most recent version. However, 0.18.0 is still the version shipped in both the apt and yum repositories, thus we must use pip to install the version we want. See mayeut/patchelf-pypi#87
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do?
Downgrade patchelf version from 0.18.0 to 0.17.2 due to patchelf regression
Patchelf shipped a regression in 0.18.0 and has since yanked the pypi release pointing to
0.17.2 as the most recent version. However, 0.18.0 is still the version shipped in both the apt and yum
repositories, thus we must use pip to install the version we want.
See mayeut/patchelf-pypi#87
Checklist
<commit_type>: <Title>Commit Type:
Check the conventional commit type
box here and add the label to the github PR.
Related PRs:
Where should the reviewer start?
Test plan:
Core
L0_*tests were segfaulting on loading a shared library used by the pytorch backend. Now they are failing due to known issues with the TensorRT backend.22812543
Caveats:
Background
No further explanation required.
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)