Update extra_requires with recent changes fix #389 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the key "Cache-Control" in AWS_S3_OBJECT_PARAMETERS, I got this error: > ValueError: Invalid extra_args key 'Cache-Control', must be one of: ACL, CacheControl, ContentDisposition, ContentEncoding, ContentLanguage, ContentType, Expires, GrantFullControl, GrantRead, GrantReadACP, GrantWriteACP, Metadata, RequestPayer, ServerSideEncryption, StorageClass, SSECustomerAlgorithm, SSECustomerKey, SSECustomerKeyMD5, SSEKMSKeyId, WebsiteRedirectLocation I fixed it by replacing "Cache-Control" with "CacheControl". I fixed the documentation to use the correct key, and to remove the word arbitrary, since it doesn't seem arbitrary to me.
* Add security token support * Add session token support for s3boto3
* Add a centralized check for getting a key with preload metadata logic * Fix timezone overwriting for collectstatic on Django < 1.10 * Add support for `get_modified_time`
Included note indicating that AWS_S3_CUSTOM_DOMAIN must *not* end in a slash. It is required that `STATIC_URL` must end in a trailing slash, and if users are using CloudFront, their `STATIC_URL` and `AWS_S3_CUSTOM_DOMAIN` values will be the same. It is very easy for users to miss the trailing `/` and instead set `AWS_S3_CUSTOM_DOMAIN = STATIC_URL`.
The "gcloud" Python module is now called "google.cloud", so use the new name. This means the name of this module needs to change too, since it can no longer be "google".
This decorator is required to allow Django 1.7 migrations to serialize
instances of this class. Without the decorator, running "makemigrations"
on code like the following will fail with a "Cannot Serialize" error.
from storages.backends.gcloud import GoogleCloudStorage
gcs = GoogleCloudStorage()
class SomeModel(models.Models):
some_field = models.FileField(storage=gcs)
According to https://googlecloudplatform.github.io/google-cloud-python/stable/storage-blobs.html#google.cloud.storage.blob.Blob.upload_from_file it's not actually necessary to specify a MIME type.
We want to use this in the Google Cloud Storage backend as well. This is a separate commit so we can verify the clean_name tests in s3boto still pass (before I move those as well).
This is used by s3boto to support the AWS_LOCATION setting, which isn't needed by Google Cloud Storage
Documentation for boto3 recommends a session per thread - https://boto3.readthedocs.io/en/latest/guide/resources.html#multithreading-multiprocessing As the storage class is (usually) only instantiated once per process, we need to set a thread local for each thread/connection used. Fixes jschneier#268
* Fix .save method of the Dropbox backend (jschneier#378) * Dropbox large file support (jschneier#301) * Make linter happy
|
Great work for jschneier#274, shame the PR isn't merged. This should address the comments on it, and minimize your time. Appreciate you might not be using this anymore maybe? |
As per PR comment: - remove deprecated backend - correct extra require for google cloud - update minimum version for dropbox
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per PR comment: