ui: update store details page #2
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
requires cockroachdb#26802 for new `StoresResponse` fields. This adds basic file stats to the stores report page. Also improves the styling: - show decoded key info protobuf fields rather than raw proto (eg: creation date rather than unix timestamp) - table styling moved to core style file - full-width cells to head different sections Release note (admin ui change): add encryption statistics on stores report page
Use the Loading component and reselect to manage the Store details page component lifecycle. Release note: None.
mberhault
force-pushed
the
marc/file_stats_on_stores_report
branch
3 times, most recently
from
5dace8a to
3145049
Compare
mberhault
pushed a commit
that referenced
this pull request
Aug 22, 2018
The PushFilterIntoJoinLeftAndRight and TryDecorrelateSelect rules can cycle with one another in a rare case: 1. Right side of join has outer column due to being un-decorrelatable. 2. Filter conjunct is pushed down to both left and right side by mapping equivalencies in PushFilterIntoJoinLeftAndRight. 3. Left conjunct is pulled back up to join condition by TryDecorrelateSelect. Steps #2 and cockroachdb#3 will cycle with one another. Cycle detection is not possible in this case, because the left side keeps changing (because new conjuct is pushed down to it each time). The fix is simple: don't let PushFilterIntoJoinLeftAndRight push down filters if either the left or right side has outer column(s). This fixes cockroachdb#28818. Release note: None
mberhault
pushed a commit
that referenced
this pull request
Aug 22, 2018
28340: storage: make lease rebalancing decisions at the store level r=a-robinson a=a-robinson In order to better balance the QPS being served by each store to avoid overloaded nodes. Fixes cockroachdb#21419 Release note (performance improvement): Range leases will be automatically rebalanced throughout the cluster to even out the amount of QPS being handled by each node. 28848: opt: Fix rule cycle bug r=andy-kimball a=andy-kimball The PushFilterIntoJoinLeftAndRight and TryDecorrelateSelect rules can cycle with one another in a rare case: 1. Right side of join has outer column due to being un-decorrelatable. 2. Filter conjunct is pushed down to both left and right side by mapping equivalencies in PushFilterIntoJoinLeftAndRight. 3. Left conjunct is pulled back up to join condition by TryDecorrelateSelect. Steps #2 and cockroachdb#3 will cycle with one another. Cycle detection is not possible in this case, because the left side keeps changing (because new conjuct is pushed down to it each time). The fix is simple: don't let PushFilterIntoJoinLeftAndRight push down filters if either the left or right side has outer column(s). This fixes cockroachdb#28818. Release note: None Co-authored-by: Alex Robinson <alexdwanerobinson@gmail.com> Co-authored-by: Andrew Kimball <andyk@cockroachlabs.com>
mberhault
pushed a commit
that referenced
this pull request
May 22, 2019
There are (at least) 3 issues that are currently causing the SQLSmith nightly test to fail: 1. Issue cockroachdb#36830 - panic: windowNode can't be run in local mode 2. Panic when calling builtin functions with ANY parameters 3. Panic when json_build_object is called with DBitArray datum This commit fixes #2 and cockroachdb#3: 2. SQLSmith now generates a random datum type when it encounters an ANY param. 3. Add DBitArray to the list of datums handled by the json_build_object function. In addition, the fix for #2 exposed a SQLSmith bug, where it ws unable to parse the type names of existing tables. The fix is to change typeFromName to use parser.ParseType. After these fixes, and once issue cockroachdb#36830 is fixed, the SQLSmith tests should start passing again in nightlies. Release note (sql change): Fix panic when json_build_object is called with BIT/VARBIT values.
mberhault
pushed a commit
that referenced
this pull request
May 22, 2019
37057: sql: Fix issues causing failures in SQLSmith r=andy-kimball a=andy-kimball There are (at least) 3 issues that are currently causing the SQLSmith nightly test to fail: 1. Issue cockroachdb#36830 - panic: windowNode can't be run in local mode 2. Panic when calling builtin functions with ANY parameters 3. Panic when json_build_object is called with DBitArray datum This commit fixes #2 and cockroachdb#3: 2. SQLSmith now generates a random datum type when it encounters an ANY param. 3. Add DBitArray to the list of datums handled by the json_build_object function. In addition, the fix for #2 exposed a SQLSmith bug, where it ws unable to parse the type names of existing tables. The fix is to change typeFromName to use parser.ParseType. After these fixes, and once issue cockroachdb#36830 is fixed, the SQLSmith tests should start passing again in nightlies. Release note (sql change): Fix panic when json_build_object is called with BIT/VARBIT values. Co-authored-by: Andrew Kimball <andyk@cockroachlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the Loading component and reselect to manage the Store details
page component lifecycle.
Release note: None.