Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(DebugView): trip, stop, vehicle ids #538

Merged
merged 3 commits into from
Nov 20, 2024

Merge branch 'main' into kb-debug-2

5deea9d
Select commit
Loading
Failed to load commit list.
Merged

feat(DebugView): trip, stop, vehicle ids #538

Merge branch 'main' into kb-debug-2
5deea9d
Select commit
Loading
Failed to load commit list.
Xcode Cloud / MBTA Transit Staging | PR Branch Workflow | iosAppRetries - iOS succeeded Nov 20, 2024 in 23m 43s

44 warnings

Report Summary
Errors 0
Test Failures 0
Analysis Issues 0
Warnings 44

Details

44 Warnings

Details

  iosApp/iosApp/Pages/More/MoreSection.swift:38
      Line Length Violation: Line should be 120 characters or less; currently it has 122 characters (line_length)
  iosApp/iosAppTests/Views/OptionalNavigationLinkTests.swift:41
      Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument (multiple_closures_with_trailing_closure)
  iosApp/iosApp/Utils/RouteTypeExtension.swift:23
      Void Function in Ternary Violation: Using ternary to call Void functions should be avoided (void_function_in_ternary)
  iosApp/iosAppTests/ViewModels/ErrorBannerViewModelTests.swift:24
      Instance method 'wait' is unavailable from asynchronous contexts; Use await fulfillment(of:timeout:enforceOrder:) instead; this is an error in Swift 6
  iosApp/iosApp/ViewModels/SearchViewModel.swift:122
      Redundant Optional Initialization Violation: Initializing an optional variable with nil is redundant (redundant_optional_initialization)
  iosApp/iosApp/Utils/RouteTypeExtension.swift:18
      Void Function in Ternary Violation: Using ternary to call Void functions should be avoided (void_function_in_ternary)
  iosApp/iosApp/Pages/Onboarding/OnboardingScreenView.swift:148
      Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument (multiple_closures_with_trailing_closure)
  iosApp/iosApp/Fetchers/ViewportProvider.swift:141
      Unused Optional Binding Violation: Prefer `!= nil` over `let _ =` (unused_optional_binding)
  iosApp/iosApp/Pages/TripDetails/TripDetailsPage.swift:14
      Type Body Length Violation: Type body should span 250 lines or less excluding comments and whitespace: currently spans 307 lines (type_body_length)
  iosApp/iosAppUITests/HomeMapViewUITests.swift:79
      Initialization of immutable value 'springboard' was never used; consider replacing with assignment to '_' or removing it
  iosApp/iosApp/Pages/StopDetails/StopDetailsPage.swift:192
      Initialization of immutable value 'errorKey' was never used; consider replacing with assignment to '_' or removing it
  iosApp/iosApp/Pages/Map/AnnotatedMap.swift:35
      'MapContentGestureContext' is deprecated: renamed to 'InteractionContext'
  iosApp/iosApp/Utils/RouteTypeExtension.swift:21
      Void Function in Ternary Violation: Using ternary to call Void functions should be avoided (void_function_in_ternary)
  iosApp/iosApp/ViewModels/SettingsViewModel.swift:92
      Line Length Violation: Line should be 120 characters or less; currently it has 123 characters (line_length)
  iosApp/iosApp/Pages/Map/HomeMapViewHandlerExtension.swift:281
      Todo Violation: TODOs should be resolved (figure out something to do if ...) (todo)
  iosApp/iosApp/Pages/Onboarding/OnboardingScreenView.swift:81
      Line Length Violation: Line should be 120 characters or less; currently it has 139 characters (line_length)
  iosApp/iosApp/Pages/Map/MapLayerManager.swift:73
      Line Length Violation: Line should be 120 characters or less; currently it has 123 characters (line_length)
  iosApp/iosApp/ProductionAppView.swift:84
      Expression implicitly coerced from 'URLResponse?' to 'Any'
  iosApp/iosApp/Pages/NearbyTransit/NearbyTransitView.swift:561
      File Length Violation: File should contain 400 lines or less: currently contains 561 (file_length)
  iosApp/iosAppTests/Views/ContentViewTests.swift:143
      Immutable value 'newConfig' was never used; consider replacing with '_' or removing it
  iosApp/iosApp/Pages/StopDetails/StopDetailsFilteredRouteView.swift:194
      Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument (multiple_closures_with_trailing_closure)
  iosApp/iosAppTests/Pages/Map/MapViewModelTests.swift:20
      Initialization of immutable value 'mapVM' was never used; consider replacing with assignment to '_' or removing it
  iosApp/iosApp/ViewModels/SettingsViewModel.swift:84
      Line Length Violation: Line should be 120 characters or less; currently it has 124 characters (line_length)
  iosApp/iosApp/Pages/More/MoreLink.swift:14
      Redundant Optional Initialization Violation: Initializing an optional variable with nil is redundant (redundant_optional_initialization)
  iosApp/iosApp/ComponentViews/LocationAuthButton.swift:85
      Line Length Violation: Line should be 120 characters or less; currently it has 137 characters (line_length)
  iosApp/iosApp/ContentView.swift:7
      Type Body Length Violation: Type body should span 250 lines or less excluding comments and whitespace: currently spans 295 lines (type_body_length)
  iosApp/iosApp/Pages/Onboarding/OnboardingScreenView.swift:134
      Line Length Violation: Line should be 120 characters or less; currently it has 124 characters (line_length)
  iosApp/iosApp/Utils/UIWindowExtension.swift:16
      Prefer For-Where Violation: `where` clauses are preferred over a single `if` inside a `for` (for_where)
  iosApp/iosApp/ComponentViews/UpcomingTripView.swift:150
      Line Length Violation: Line should be 120 characters or less; currently it has 139 characters (line_length)
  iosApp/iosApp/Pages/Map/MapHttpInterceptor.swift:31
      Immutable value 'error' was never used; consider replacing with '_' or removing it
  iosApp/iosApp/Pages/AlertDetails/AlertDetails.swift:31
      Todo Violation: TODOs should be resolved (Add all possible alert effects...) (todo)
  iosApp/iosApp/Pages/Map/HomeMapViewHandlerExtension.swift:242
      'MapContentGestureContext' is deprecated: renamed to 'InteractionContext'
  iosApp/iosApp/ComponentViews/ErrorBanner.swift:56
      Line Length Violation: Line should be 120 characters or less; currently it has 126 characters (line_length)
  iosApp/iosApp/ComponentViews/ActionButton.swift:78
      Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument (multiple_closures_with_trailing_closure)
  iosApp/iosApp/Pages/NearbyTransit/NearbyTransitView.swift:17
      Type Body Length Violation: Type body should span 250 lines or less excluding comments and whitespace: currently spans 312 lines (type_body_length)
  iosApp/iosApp/Pages/Onboarding/OnboardingScreenView.swift:144
      Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument (multiple_closures_with_trailing_closure)
  iosApp/iosApp/ViewModels/ErrorBannerViewModel.swift:17
      Redundant Optional Initialization Violation: Initializing an optional variable with nil is redundant (redundant_optional_initialization)
  iosApp/iosApp/Pages/StopDetails/StopDetailsFilterPills.swift:77
      Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument (multiple_closures_with_trailing_closure)
  iosApp/iosApp/ComponentViews/SheetNavigationLink.swift:21
      Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument (multiple_closures_with_trailing_closure)
  iosApp/iosApp/ViewModels/SettingsViewModel.swift:66
      Line Length Violation: Line should be 120 characters or less; currently it has 150 characters (line_length)
  iosApp/iosAppTests/Pages/NearbyTransit/RouteCardTests.swift:22
      Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument (multiple_closures_with_trailing_closure)
  iosApp/iosApp/Utils/FetchApi.swift:35
      Immutable value 'error' was never used; consider replacing with '_' or removing it
  iosApp/iosApp/ComponentViews/PredictionRowView.swift:37
      Todo Violation: TODOs should be resolved (Properly localize all possible...) (todo)
  iosApp/iosApp/Pages/NearbyTransit/StopDeparturesSummaryList.swift:38
      Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument (multiple_closures_with_trailing_closure)

Annotations

Check notice on line 14 in iosApp/iosApp/Pages/TripDetails/TripDetailsPage.swift

See this annotation in the file changed.

@xcode-cloud xcode-cloud / MBTA Transit Staging | PR Branch Workflow | iosAppRetries - iOS

iosApp/iosApp/Pages/TripDetails/TripDetailsPage.swift#L14

Type Body Length Violation: Type body should span 250 lines or less excluding comments and whitespace: currently spans 307 lines (type_body_length)

Check notice on line 7 in iosApp/iosApp/ContentView.swift

See this annotation in the file changed.

@xcode-cloud xcode-cloud / MBTA Transit Staging | PR Branch Workflow | iosAppRetries - iOS

iosApp/iosApp/ContentView.swift#L7

Type Body Length Violation: Type body should span 250 lines or less excluding comments and whitespace: currently spans 295 lines (type_body_length)

Check notice on line 56 in iosApp/iosApp/ComponentViews/ErrorBanner.swift

See this annotation in the file changed.

@xcode-cloud xcode-cloud / MBTA Transit Staging | PR Branch Workflow | iosAppRetries - iOS

iosApp/iosApp/ComponentViews/ErrorBanner.swift#L56

Line Length Violation: Line should be 120 characters or less; currently it has 126 characters (line_length)