feat: Initial new stop page trip details UI #572
Merged
Xcode Cloud / MBTA Transit Staging | PR Branch Workflow | iosAppRetries - iOS
succeeded
Dec 10, 2024 in 34m 43s
45 warnings
| Report Summary | |
|---|---|
| Errors | 0 |
| Test Failures | 0 |
| Analysis Issues | 0 |
| Warnings | 45 |
Details
45 Warnings
Details
iosApp/iosApp/Pages/NearbyTransit/NearbyTransitView.swift:17
Type Body Length Violation: Type body should span 250 lines or less excluding comments and whitespace: currently spans 315 lines (type_body_length)
Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument (multiple_closures_with_trailing_closure)
Prefer For-Where Violation: `where` clauses are preferred over a single `if` inside a `for` (for_where)
Line Length Violation: Line should be 120 characters or less; currently it has 123 characters (line_length)
Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument (multiple_closures_with_trailing_closure)
Line Length Violation: Line should be 120 characters or less; currently it has 122 characters (line_length)
'MapContentGestureContext' is deprecated: renamed to 'InteractionContext'
Void Function in Ternary Violation: Using ternary to call Void functions should be avoided (void_function_in_ternary)
Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument (multiple_closures_with_trailing_closure)
Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument (multiple_closures_with_trailing_closure)
Unused Optional Binding Violation: Prefer `!= nil` over `let _ =` (unused_optional_binding)
Line Length Violation: Line should be 120 characters or less; currently it has 139 characters (line_length)
Immutable value 'error' was never used; consider replacing with '_' or removing it
Type Body Length Violation: Type body should span 250 lines or less excluding comments and whitespace: currently spans 307 lines (type_body_length)
Initialization of immutable value 'mapVM' was never used; consider replacing with assignment to '_' or removing it
Immutable value 'tripFilter' was never used; consider replacing with '_' or removing it
Redundant Optional Initialization Violation: Initializing an optional variable with nil is redundant (redundant_optional_initialization)
Line Length Violation: Line should be 120 characters or less; currently it has 126 characters (line_length)
Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument (multiple_closures_with_trailing_closure)
'MapContentGestureContext' is deprecated: renamed to 'InteractionContext'
Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument (multiple_closures_with_trailing_closure)
Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument (multiple_closures_with_trailing_closure)
Redundant Optional Initialization Violation: Initializing an optional variable with nil is redundant (redundant_optional_initialization)
Initialization of immutable value 'springboard' was never used; consider replacing with assignment to '_' or removing it
File Length Violation: File should contain 400 lines or less: currently contains 564 (file_length)
Void Function in Ternary Violation: Using ternary to call Void functions should be avoided (void_function_in_ternary)
Instance method 'wait' is unavailable from asynchronous contexts; Use await fulfillment(of:timeout:enforceOrder:) instead; this is an error in Swift 6
Redundant Optional Initialization Violation: Initializing an optional variable with nil is redundant (redundant_optional_initialization)
Line Length Violation: Line should be 120 characters or less; currently it has 124 characters (line_length)
Line Length Violation: Line should be 120 characters or less; currently it has 139 characters (line_length)
Redundant Optional Initialization Violation: Initializing an optional variable with nil is redundant (redundant_optional_initialization)
Todo Violation: TODOs should be resolved (figure out something to do if ...) (todo)
Immutable value 'error' was never used; consider replacing with '_' or removing it
Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument (multiple_closures_with_trailing_closure)
Expression implicitly coerced from 'URLResponse?' to 'Any'
Type Body Length Violation: Type body should span 250 lines or less excluding comments and whitespace: currently spans 282 lines (type_body_length)
Line Length Violation: Line should be 120 characters or less; currently it has 137 characters (line_length)
Line Length Violation: Line should be 120 characters or less; currently it has 124 characters (line_length)
Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument (multiple_closures_with_trailing_closure)
Line Length Violation: Line should be 120 characters or less; currently it has 150 characters (line_length)
Line Length Violation: Line should be 120 characters or less; currently it has 123 characters (line_length)
Void Function in Ternary Violation: Using ternary to call Void functions should be avoided (void_function_in_ternary)
Type Body Length Violation: Type body should span 250 lines or less excluding comments and whitespace: currently spans 321 lines (type_body_length)
Todo Violation: TODOs should be resolved (Add all possible alert effects...) (todo)
Line Length Violation: Line should be 120 characters or less; currently it has 137 characters (line_length)
Annotations
Check notice on line 324 in iosApp/iosApp/ViewModels/StopDetailsViewModel.swift
xcode-cloud / MBTA Transit Staging | PR Branch Workflow | iosAppRetries - iOS
iosApp/iosApp/ViewModels/StopDetailsViewModel.swift#L324
Redundant Optional Initialization Violation: Initializing an optional variable with nil is redundant (redundant_optional_initialization)
Check notice on line 150 in iosApp/iosApp/ComponentViews/UpcomingTripView.swift
xcode-cloud / MBTA Transit Staging | PR Branch Workflow | iosAppRetries - iOS
iosApp/iosApp/ComponentViews/UpcomingTripView.swift#L150
Line Length Violation: Line should be 120 characters or less; currently it has 139 characters (line_length)
Check notice on line 41 in iosApp/iosApp/ViewModels/StopDetailsViewModel.swift
xcode-cloud / MBTA Transit Staging | PR Branch Workflow | iosAppRetries - iOS
iosApp/iosApp/ViewModels/StopDetailsViewModel.swift#L41
Type Body Length Violation: Type body should span 250 lines or less excluding comments and whitespace: currently spans 282 lines (type_body_length)
Loading