fix(subscribeToPredictions): ensure old data present when merging in new data #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackVCurtis
reviewed
Dec 18, 2024
|
|
||
| val predictions: StateFlow<PredictionsByStopJoinResponse?> = _predictions | ||
| val predictionsFlow = | ||
| predictions.map { it?.toPredictionsStreamDataResponse() }.debounce(0.1.seconds) |
There was a problem hiding this comment.
Is the ordering of map vs. debounce relevant?
There was a problem hiding this comment.
Oh good point, I'll swap to the two to avoid excessive maps
KaylaBrady
commented
Dec 18, 2024
| @@ -61,7 +63,7 @@ fun subscribeToAlerts( | |||
| val viewModel: AlertsViewModel = viewModel(factory = AlertsViewModel.Factory(alertsRepository)) | |||
|
|
|||
| LifecycleResumeEffect(key1 = null) { | |||
| viewModel.connect() | |||
| CoroutineScope(Dispatchers.IO).launch { viewModel.connect() } | |||
There was a problem hiding this comment.
@JackVCurtis added the use of Dipsatchers.IO in #557, and I mistakenly removed in #588.
This addresses some of the jankiness / lag while panning the map or scrolling the list of departures.
Applying across all channels.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket: 🤖 | Nearby | Predictions unavailable more than expected
What is this PR for?
Nearby Transit was getting stuck showing "Predictions Unavailable" For routes that had predictions, such as RL. Predictions reliably loaded in Stop Details, but not in Nearby Transit.
After adding debug logs, it seems the issue is that where we merge new predictions messages with the current state of predictions, the current state of predictions is out of date & often null, so we lose predictions from earlier messages. The docs for LiveData.getValue() mention
Whereas StateFlow:
iOS
android
Testing
What testing have you done?