fix: duplicate route registration in tests #948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent change in the Laravel framework (laravel/framework#56920) has caused the
testSetLocaletest of this package to fail.After some digging, it turns out the test suite was registering routes multiple times. This happens via the
setRoutesmethod, which is called in bothrefreshApplicationandgetEnvironmentSetUp.The recent Laravel change modified how routes are prioritized, meaning the last registered route is no longer guaranteed to be matched first. While the framework update caused this issue to pop up, the underlying problem has existed in this package for some time.
This fixes #943.