Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: request creation when double slashes exist #61

Merged
merged 1 commit into from
Feb 1, 2023

Conversation

mcansh
Copy link
Owner

@mcansh mcansh commented Feb 1, 2023

@see: remix-run/remix#5336

Signed-off-by: Logan McAnsh logan@mcan.sh

@see: remix-run/remix#5336

Signed-off-by: Logan McAnsh <logan@mcan.sh>
@changeset-bot
Copy link

changeset-bot bot commented Feb 1, 2023

⚠️ No Changeset found

Latest commit: a4e4317

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mcansh mcansh merged commit 7205ae3 into main Feb 1, 2023
@mcansh mcansh deleted the logan/double-slashes-invalid-url branch February 1, 2023 20:45
mcansh added a commit that referenced this pull request Feb 1, 2023
Signed-off-by: Logan McAnsh <logan@mcan.sh>
mcansh added a commit to philipp-spiess/remix-fastify that referenced this pull request Feb 24, 2023
mcansh added a commit that referenced this pull request Feb 24, 2023
* Upgrade Remix

* Match static files in dev against the pathname

* Add changelog

* chore: update url creation so doubleslashes dont cause an issue #61

Signed-off-by: Logan McAnsh <logan@mcan.sh>

---------

Signed-off-by: Logan McAnsh <logan@mcan.sh>
Co-authored-by: Logan McAnsh <logan@mcan.sh>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant