fix: match static files in dev based on the pathname to fix HMR #69
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue that I observed while trying out the HMR prerelease build of Remix.
When Remix makes the HMR request, it adds a
?t=123
parameter to the URL for cache busting. The fastify adapter however did not properly resolve these static assets because it was comparing url (e.g.build/routes/foo.js?t=123
) with the filename using string equality.This fixes the issue by parsing the URL and comparing the pathname instead.
To make the example run locally, I also had to upgrade to Remix 1.13.0 (1.12.0 had some issues loading the flat routes properly, somehow it was looking for them in
/outes
instead/routes
😅 ). I included this as a separate commit in this PR but I’m happy to remove it.It doesn't seem like there's a setup for testing the full fastify plugin end-to-end so I verified this based on the example app and
curl
instead:Before
After