-
-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Zstd as a ZIP compression method #132
Comments
I will add both IDs ... what ID should be preferred, when creating an |
I have written an email to PKWARE and WinZip. Maybe I get some response for the two IDs issue ;-) The code is nearly finished, but I will wait for the response of them. |
Minizip adopts a compatible solution, that is, it supports magic number 20/93 at the same time, which is used to support ZIP (zstd). Magic number 20 is used when creating compressed files. https://github.com/nmoinvaz/minizip/blob/dev/mz_strm_zstd.c |
@ipaucek4680 If I have time this weekend, I will give it a try. |
@mcmilk
|
@fcharlie, Thanks for the update. I don't think there are users who have Zstd ZIP files with the deprecated ID 20 (by using minizip) and therefore we can consider removing the usage of ID 20. However, if backward compatibility is desired, how should we name the two IDs now? OldZstd for 20 and Zstd for 93? |
@ipaucek4680 If necessary, I might create a new PR for minizip |
By the way, I think PKWARE forgot to add an entry for Zstd in APPNOTE Section 4.4.3.2 (version needed to extract). It should be 6.3 since Zstd is added to the specification in revision 6.3.7. |
Supporting both 20 and 93 at decompression is probably the better idea for me |
@gvollant I have some differences from yours. In a short period of time, the compression method magic number 20 was granted to zstd, and then it was not recommended to use, but 93 was assigned to zstd. This time is too short to be available in many software. Support'zstd(20)' in a timely manner, so, in my opinion, support 20 is no longer necessary, PKWARE has abandoned the difference, and chose to be consistent with WinZip, so we don't need to do too much compatibility. My PR for archiver, libzip and this project no longer support 20, and I will also initiate a new PR to fix minizip support for zip(zstd) Thanks. |
It's in now ;) |
So it is possible to convert older slow zip-files to zip-93-zstd without changing names? very interesting for administrators and users with many old zip files. great work and thanks by a little user. |
Please refer to p7zip-project/p7zip#25 (comment) for the detailed description.
Key points:
The text was updated successfully, but these errors were encountered: