-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zip adds zstd compression algorithm support #181
Conversation
I can confirm that extraction of Zstd ZIP file (created by WinZip) is working. For compression/modification, I guess We may also need to set the "version needed to extract". |
@ipaucek4680 I’m not sure which value |
This is a test file created by WinZip: If you run
So I believe that |
@ipaucek4680 already updated |
Thanks. I noticed that this repository contains a copy of the APPNOTE.txt, but section 1.4.2 states that "any reproduction or distribution of this document in whole or in part without prior written permission from PKWARE is strictly prohibited"...... |
@ipaucek4680 APPNOTE.txt already existed before. Is it necessary to reauthorize to update APPNOTE.txt? I am not very clear about this. If there is a problem, I will withdraw the APPNOTE.txt update. |
@ipaucek4680 I have undo the update of appnote.txt |
Well, according to the Git history, the file is added in 2004 (16 years ago) and the commit messages do not say whether the developers were authorized to maintain a copy of it in the repo...... @0-wiz-0 |
Thank you! We cleaned it up and merged it. |
Recently, the zip specification file added 93 as the magic number of the zstd algorithm (initially 20, but WinZip used 93 and later changed to 93). This PR mainly implements support for zstd. This PR may not be tested enough, but I Here, unzipping the zip(zstd) file is successful.
It should be noted that this version does not implement support for compression levels, and may require some minor adjustments.
zip(zstd) related:
mcmilk/7-Zip-zstd#132
mholt/archiver#223
zlib-ng/minizip-ng#498
@ipaucek4680 If you are interested, you can try it.