Skip to content
This repository has been archived by the owner on Nov 19, 2024. It is now read-only.

Support decompression compression algorithm using zstd/lzma/bzip2 zip file. #223

Merged
merged 9 commits into from
Jun 26, 2020
Merged

Support decompression compression algorithm using zstd/lzma/bzip2 zip file. #223

merged 9 commits into from
Jun 26, 2020

Conversation

fcharlie
Copy link
Contributor

According to the latest zip file format specification APPNOTE.TXT, zstd has been accepted as the algorithm supported by zip, the number is 20, this PR gives people to create and decompress zip files using zstd compression algorithm.

Follow-up of other compression software:
mcmilk/7-Zip-zstd#132
p7zip-project/p7zip#25

Restriction: When creating a zip(zstd) file, setting the compression level is not supported

Copy link
Owner

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks interesting! Just a few comments to tidy things up.

Also can you add tests for this?

zip.go Outdated Show resolved Hide resolved
zip.go Outdated Show resolved Hide resolved
zip.go Outdated Show resolved Hide resolved
Copy link
Owner

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!

@mholt mholt merged commit d44471c into mholt:master Jun 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants