-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for docutils 0.18 and 0.19 and raise a helpful warning if it is installed #322
Comments
To add; I don't think we can fix this by updating the packaging metadata, as any current Python package installer with backsolve to find a version that doesn't have the pin. This would not be the desired behaviour. @choldgraf suggestion to error at run-time is the best that we can do here, and allows users to specify Let us know if we can do anything to help here. |
Yes, it's annoying that docutils still haven't released the fix. I agree with your analysis. I expect I will have time to give the extension a bit of love again after mid March. Feel free to make a PR in the meantime if you wish, and I'll do my best to review and merge. |
…tils>=0.18,<0.20 (#1965) * pin docutils < 0.18 (mcmtroffaes/sphinxcontrib-bibtex#322) * Prep for v0.15.1 * rework, issue warning rather than force version pin on docutils * only test html if no warnings * doc: add entry for citations page * update changelog
I think |
This is now fixed in #330 which was just merged. |
As we've discovered in #309, there is a nasty docutils bug in 0.18 and 0.19 that will break this extension in hidden ways (where people won't get an error, the page will just be wrong).
Since 0.20 isn't released yet, could we add a short-term quality of life fix to raise an error and give users guidance? I imagine a little function that triggers on
config-inited
and does the following:0.18 >= docutils version < 0.20
docutils==0.17
andsphinx==5
until docutils 0.20 is released."It could be a lightweight way to point people in the right direction if they hit this bug, given that getting the right versions installed will require a bit of searching.
The text was updated successfully, but these errors were encountered: