Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circumvent docutils bug #330

Merged
merged 13 commits into from
Jun 5, 2023

Conversation

flying-sheep
Copy link
Contributor

Fixes #329

@mcmtroffaes
Copy link
Owner

Oh, swell, glad to have 0.20 out finally! Will merge once tests pass.

@mcmtroffaes
Copy link
Owner

Some tests need to be fixed for the new docutils; I suspect the format of the generated html has changed slightly.

@mcmtroffaes mcmtroffaes self-assigned this Jun 5, 2023
@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Merging #330 (2b73057) into develop (03d924b) will decrease coverage by 0.41%.
The diff coverage is 100.00%.

❗ Current head 2b73057 differs from pull request most recent head 03830da. Consider uploading reports for the commit 03830da to get more accurate results

@@             Coverage Diff             @@
##           develop     #330      +/-   ##
===========================================
- Coverage   100.00%   99.59%   -0.41%     
===========================================
  Files           52       52              
  Lines         2482     2483       +1     
  Branches       435      377      -58     
===========================================
- Hits          2482     2473       -9     
- Misses           0        5       +5     
- Partials         0        5       +5     
Impacted Files Coverage Δ
test/common.py 78.37% <100.00%> (-21.63%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mcmtroffaes
Copy link
Owner

Older docutils versions aren't broken, so instead I've gone for excluding 0.18 and 0.19 which are known to be affected by this bug. Thanks again!

@mcmtroffaes mcmtroffaes merged commit ba61382 into mcmtroffaes:develop Jun 5, 2023
@flying-sheep flying-sheep deleted the fix-docutils-html branch June 6, 2023 07:32
@casperdcl casperdcl mentioned this pull request Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid HTML generated
2 participants